From: Daniel Herzig <d.herzig@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 1/12] fix #4225: qemuserver: drive: add optional required parameter
Date: Mon, 13 Jan 2025 09:55:57 +0100 [thread overview]
Message-ID: <20250113085608.99498-2-d.herzig@proxmox.com> (raw)
In-Reply-To: <20250113085608.99498-1-d.herzig@proxmox.com>
Add parameter to allow for marking a drive as required.
Signed-off-by: Daniel Herzig <d.herzig@proxmox.com>
---
PVE/QemuServer/Drive.pm | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm
index 7b298454..b816fbec 100644
--- a/PVE/QemuServer/Drive.pm
+++ b/PVE/QemuServer/Drive.pm
@@ -193,7 +193,14 @@ my %drivedesc_base = (
verbose_description => "Mark this locally-managed volume as available on all nodes.\n\nWARNING: This option does not share the volume automatically, it assumes it is shared already!",
optional => 1,
default => 0,
- }
+ },
+ required => {
+ type => 'boolean',
+ description => 'Mark this iso volume as required for booting the VM.',
+ verbose_description => 'If unset or set to 1, and the iso file is unavailable, the VM will not start.\nThis parameter is considered for cdrom iso drives only.',
+ optional => 1,
+ default => 1,
+ },
);
my %iothread_fmt = ( iothread => {
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-01-13 8:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 8:55 [pve-devel] [PATCH v2 qemu-server, manager 00/12] bugzilla #4225 -- improve handling of unavailable ISOs Daniel Herzig
2025-01-13 8:55 ` Daniel Herzig [this message]
2025-01-13 8:55 ` [pve-devel] [PATCH v2 2/12] qemuserver: add helper function for mocking files Daniel Herzig
2025-01-16 15:18 ` Daniel Kral
2025-01-17 11:36 ` Daniel Herzig
2025-01-13 8:55 ` [pve-devel] [PATCH v2 3/12] fix #4225: qemuserver: add function to eject isofiles Daniel Herzig
2025-01-16 15:19 ` Daniel Kral
2025-01-17 12:32 ` Daniel Herzig
2025-01-13 8:56 ` [pve-devel] [PATCH v2 4/12] test: chomp all trailing newlines from errors and warnings Daniel Herzig
2025-01-13 8:56 ` [pve-devel] [PATCH v2 5/12] test: mock cifs-store Daniel Herzig
2025-01-13 8:56 ` [pve-devel] [PATCH v2 6/12] test: add nfs-offline storage Daniel Herzig
2025-01-13 8:56 ` [pve-devel] [PATCH v2 7/12] test: mock existing files Daniel Herzig
2025-01-13 8:56 ` [pve-devel] [PATCH v2 8/12] test: mock log_warn warnings Daniel Herzig
2025-01-13 8:56 ` [pve-devel] [PATCH v2 9/12] test: cfg2cmd: add tests for testing the iso required parameter Daniel Herzig
2025-01-13 8:56 ` [pve-devel] [PATCH v2 10/12] fix #4225: ui: form: isoselector: add optional required checkbox Daniel Herzig
2025-01-13 8:56 ` [pve-devel] [PATCH v2 11/12] fix #4225: ui: qemu: cdedit: enable required checkbox for isos Daniel Herzig
2025-01-16 15:19 ` Daniel Kral
2025-01-17 12:38 ` Daniel Herzig
2025-01-13 8:56 ` [pve-devel] [PATCH v2 12/12] ui: qemu: hardware: add eject button for cdroms Daniel Herzig
2025-01-16 15:19 ` Daniel Kral
2025-01-17 12:47 ` Daniel Herzig
2025-01-23 16:39 ` Friedrich Weber
2025-01-24 7:35 ` Daniel Herzig
2025-01-16 15:18 ` [pve-devel] [PATCH v2 qemu-server, manager 00/12] bugzilla #4225 -- improve handling of unavailable ISOs Daniel Kral
2025-01-17 11:34 ` Daniel Herzig
2025-01-17 13:04 ` Daniel Kral
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250113085608.99498-2-d.herzig@proxmox.com \
--to=d.herzig@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox