[pve-devel] [PATCH v2 qemu-server, manager 00/12] bugzilla #4225 -- improve handling of unavailable ISOs

[Daniel Herzig <d.herzig@proxmox.com>]

This patch series addresses bugzilla entry #4225.

Currently VMs refuse to to start if a configured isofile becomes unavailable,
be it a deleted file or an unavailable network storage.

This patch series introduces a new parameter in Drive.pm, called 'required'.
Depending on whether this parameter is set or not, the situation will be handled
differently.

If the parameter is set to 0, the configuration will temporarily changed to use
'none' as file for the cd drive, which allows qemu to start up the machine.
The configuration is not changed in this process to avoid unexpected behaviour.
Instead a log_warn will be issued.

For transition reasons an unset parameter acts like 'required=1'. In this case
the startup process will die earlier than currently, if the file is missing or
the underlying storage not available.

If however a new VM is created from the WebGUI, the corresponding added checkbox
is not checked by default, and the resulting 'required=0' will be written to
the configuration.

To allow for proper testing and building some additions and minor changes
where made to to the testing framework as well.

Not exactly part of #4225, but related to it, this patch series adds an 'Eject'
button to the hardwareview in the WebGUI, which can be used as a convenience
shortcut to manually editing the missing ISO file to 'Do not use any media'.

This series supersedes:
https://lore.proxmox.com/pve-devel/20241025150243.134466-1-d.herzig@proxmox.com/

Changes from initial series:
* rebased onto current master
* fix cifs mocking in run_config2command_tests.pl
* fix expected outcome in ide-required.conf.cmd

qemu-server: Daniel Herzig (9):
  fix #4225: qemuserver: drive: add optional required parameter
  qemuserver: add helper function for mocking files
  fix #4225: qemuserver: add function to eject isofiles
  test: chomp all trailing newlines from errors and warnings
  test: mock cifs-store
  test: add nfs-offline storage
  test: mock existing files
  test: mock log_warn warnings
  test: cfg2cmd: add tests for testing the iso required parameter

 PVE/QemuServer.pm                             | 44 +++++++++++++++++++
 PVE/QemuServer/Drive.pm                       |  9 +++-
 test/cfg2cmd/ide-required-iso-missing.conf    | 12 +++++
 .../cfg2cmd/ide-required-iso-missing.conf.cmd |  0
 .../cfg2cmd/ide-required-iso-offline-nfs.conf | 12 +++++
 .../ide-required-iso-offline-nfs.conf.cmd     |  0
 test/cfg2cmd/ide-required.conf                | 14 ++++++
 test/cfg2cmd/ide-required.conf.cmd            | 39 ++++++++++++++++
 test/cfg2cmd/ide-unrequired-iso-missing.conf  | 12 +++++
 .../ide-unrequired-iso-missing.conf.cmd       | 33 ++++++++++++++
 .../ide-unrequired-iso-offline-nfs.conf       | 12 +++++
 .../ide-unrequired-iso-offline-nfs.conf.cmd   | 33 ++++++++++++++
 test/run_config2command_tests.pl              | 44 ++++++++++++++++++-
 13 files changed, 261 insertions(+), 3 deletions(-)
 create mode 100644 test/cfg2cmd/ide-required-iso-missing.conf
 create mode 100644 test/cfg2cmd/ide-required-iso-missing.conf.cmd
 create mode 100644 test/cfg2cmd/ide-required-iso-offline-nfs.conf
 create mode 100644 test/cfg2cmd/ide-required-iso-offline-nfs.conf.cmd
 create mode 100644 test/cfg2cmd/ide-required.conf
 create mode 100644 test/cfg2cmd/ide-required.conf.cmd
 create mode 100644 test/cfg2cmd/ide-unrequired-iso-missing.conf
 create mode 100644 test/cfg2cmd/ide-unrequired-iso-missing.conf.cmd
 create mode 100644 test/cfg2cmd/ide-unrequired-iso-offline-nfs.conf
 create mode 100644 test/cfg2cmd/ide-unrequired-iso-offline-nfs.conf.cmd

manager: Daniel Herzig (3):
  fix #4225: ui: form: isoselector: add optional required checkbox
  fix #4225: ui: qemu: cdedit: enable required checkbox for isos
  ui: qemu: hardware: add eject button for cdroms

 www/manager6/form/IsoSelector.js  | 22 ++++++++++++++++
 www/manager6/qemu/CDEdit.js       |  6 +++++
 www/manager6/qemu/HardwareView.js | 43 +++++++++++++++++++++++++++++++
 3 files changed, 71 insertions(+)


-- 
2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel