From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9B6C21FF15C for ; Wed, 8 Jan 2025 10:59:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 90C411559C; Wed, 8 Jan 2025 10:58:56 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Wed, 8 Jan 2025 10:58:53 +0100 Message-Id: <20250108095853.896087-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [standard.pm] Subject: [pve-devel] [PATCH http-server] fix #6503: return api handler errors in the json body X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" similar to what we do for the extjs formatter, put the error message or status message in the 'message' property of the return object. This way client libraries can extract the error without having to parse the HTTP status reason phrase (which is not possible in all http libraries, e.g. hyperium's http rust crate). This should not be a breaking change, since it just adds a (semi) new field to the return value. Signed-off-by: Dominik Csapak --- we could of course put the error also in the 'errors' hash with a special key like '_api', but i opted for mirroring the 'extjs' formatter behaviour for consistency. src/PVE/APIServer/Formatter/Standard.pm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/PVE/APIServer/Formatter/Standard.pm b/src/PVE/APIServer/Formatter/Standard.pm index 5211473..eca928d 100644 --- a/src/PVE/APIServer/Formatter/Standard.pm +++ b/src/PVE/APIServer/Formatter/Standard.pm @@ -33,6 +33,10 @@ sub prepare_response_data { $res->{status} = 200; } $new->{success} = $success; + } elsif ($format eq 'json') { + if (HTTP::Status::is_error($res->{status})) { + $new->{message} = "$res->{message}" || status_message($res->{status}); + } } if ($success && $res->{total}) { -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel