From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D32DC1FF15C for ; Wed, 8 Jan 2025 09:46:47 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 59992137A3; Wed, 8 Jan 2025 09:46:33 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Wed, 8 Jan 2025 09:45:58 +0100 Message-Id: <20250108084558.390324-3-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250108084558.390324-1-d.csapak@proxmox.com> References: <20250108084558.390324-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [ietf.org, anyevent.pm] Subject: [pve-devel] [RFC PATCH http-server 2/2] use HTTP_INTERNAL_SERVER_ERROR were appropriate instead of '501' X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The http status code 501 is meant to be 'Not Implemented'[0] but that clearly does not fit here as the default error when we encounter a problem during handling an api request or upload. So instead use '500' (HTTP_INTERNAL_SERVER_ERROR) which we already use in other places where it fits. 0: https://datatracker.ietf.org/doc/html/rfc9110#name-501-not-implemented Signed-off-by: Dominik Csapak --- src/PVE/APIServer/AnyEvent.pm | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/PVE/APIServer/AnyEvent.pm b/src/PVE/APIServer/AnyEvent.pm index bd76488..3b96d2a 100644 --- a/src/PVE/APIServer/AnyEvent.pm +++ b/src/PVE/APIServer/AnyEvent.pm @@ -504,7 +504,7 @@ sub send_file_start { $self->response($reqstate, $resp, $mtime, $nocomp); }; if (my $err = $@) { - $self->error($reqstate, 501, $err); + $self->error($reqstate, HTTP_INTERNAL_SERVER_ERROR, $err); } }; @@ -1020,7 +1020,7 @@ sub handle_api2_request { $self->response($reqstate, $resp, undef, $nocomp, $delay); }; if (my $err = $@) { - $self->error($reqstate, 501, $err); + $self->error($reqstate, HTTP_INTERNAL_SERVER_ERROR, $err); } } @@ -1214,7 +1214,7 @@ sub handle_request { die "no such file '$path'\n"; }; if (my $err = $@) { - $self->error($reqstate, 501, $err); + $self->error($reqstate, HTTP_INTERNAL_SERVER_ERROR, $err); } } @@ -1304,7 +1304,7 @@ sub file_upload_multipart { }; if (my $err = $@) { syslog('err', $err); - $self->error($reqstate, 501, $err); + $self->error($reqstate, HTTP_INTERNAL_SERVER_ERROR, $err); } } @@ -1402,10 +1402,10 @@ sub process_header { my $te = $request->header('Transfer-Encoding'); if ($te && lc($te) eq 'chunked') { # Handle chunked transfer encoding - $self->error($reqstate, 501, "chunked transfer encoding not supported"); + $self->error($reqstate, HTTP_INTERNAL_SERVER_ERROR, "chunked transfer encoding not supported"); return 0; } elsif ($te) { - $self->error($reqstate, 501, "Unknown transfer encoding '$te'"); + $self->error($reqstate, HTTP_INTERNAL_SERVER_ERROR, "Unknown transfer encoding '$te'"); return 0; } @@ -1574,7 +1574,7 @@ sub authenticate_and_handle_request { if ($len) { if (!($method eq 'PUT' || $method eq 'POST')) { - $self->error($reqstate, 501, "Unexpected content for method '$method'"); + $self->error($reqstate, HTTP_INTERNAL_SERVER_ERROR, "Unexpected content for method '$method'"); return; } @@ -1624,7 +1624,7 @@ sub authenticate_and_handle_request { } if ($len > $limit_max_post) { - $self->error($reqstate, 501, "for data too large"); + $self->error($reqstate, HTTP_INTERNAL_SERVER_ERROR, "for data too large"); return; } -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel