From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DB00C1FF164 for ; Fri, 3 Jan 2025 16:59:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7F3F62920A; Fri, 3 Jan 2025 16:58:40 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 3 Jan 2025 16:57:44 +0100 Message-Id: <20250103155802.143669-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250103155802.143669-1-f.ebner@proxmox.com> References: <20250103155802.143669-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu 01/19] weaken machine version deprecation warning X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" In commit a35f8577a0 ("include/hw: add macros for deprecation & removal of versioned machines"), a new machine version deprecation and removal policy was introduced. After only 3 years a machine version will be deprecated while being removed after 6 years. The deprecation is a bit early considering major PVE releases are approximately every 2 years. This means that a deprecation warning can already happen for a machine version that was introduced during the previous major release. This would scare users for no good reason, so avoid deprecating machine versions in PVE too early and define a baseline of machine versions that will be supported throughout a single major PVE release. PVE will warn about deprecated machine versions when it considers them to be deprecated, so avoid a scary-sounding warning from QEMU proper and turn it into an informational message about pre-deprecation. Reported-by: Martin Maurer Signed-off-by: Fiona Ebner --- ...-machine-version-deprecation-warning.patch | 56 +++++++++++++++++++ debian/patches/series | 1 + 2 files changed, 57 insertions(+) create mode 100644 debian/patches/pve/0052-weaken-machine-version-deprecation-warning.patch diff --git a/debian/patches/pve/0052-weaken-machine-version-deprecation-warning.patch b/debian/patches/pve/0052-weaken-machine-version-deprecation-warning.patch new file mode 100644 index 0000000..b8cfc67 --- /dev/null +++ b/debian/patches/pve/0052-weaken-machine-version-deprecation-warning.patch @@ -0,0 +1,56 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Fiona Ebner +Date: Fri, 3 Jan 2025 14:03:12 +0100 +Subject: [PATCH] weaken machine version deprecation warning + +In commit a35f8577a0 ("include/hw: add macros for deprecation & +removal of versioned machines"), a new machine version deprecation and +removal policy was introduced. After only 3 years a machine version +will be deprecated while being removed after 6 years. + +The deprecation is a bit early considering major PVE releases are +approximately every 2 years. This means that a deprecation warning can +already happen for a machine version that was introduced during the +previous major release. This would scare users for no good reason, so +avoid deprecating machine versions in PVE too early and define a +baseline of machine versions that will be supported throughout a +single major PVE release. + +PVE will warn about deprecated machine versions when it considers them +to be deprecated, so avoid a scary-sounding warning from QEMU proper +and turn it into an informational message about pre-deprecation. + +Signed-off-by: Fiona Ebner +--- + include/hw/boards.h | 4 +--- + system/vl.c | 2 +- + 2 files changed, 2 insertions(+), 4 deletions(-) + +diff --git a/include/hw/boards.h b/include/hw/boards.h +index 5cddeb7fcb..4f30824b57 100644 +--- a/include/hw/boards.h ++++ b/include/hw/boards.h +@@ -619,9 +619,7 @@ struct MachineState { + * message for a versioned machine type + */ + #define MACHINE_VER_DEPRECATION_MSG \ +- "machines more than " stringify(MACHINE_VER_DEPRECATION_MAJOR) \ +- " years old are subject to deletion after " \ +- stringify(MACHINE_VER_DELETION_MAJOR) " years" ++ "machine version is rather old" + + #define _MACHINE_VER_IS_EXPIRED_IMPL(cutoff, major, minor) \ + (((QEMU_VERSION_MAJOR - major) > cutoff) || \ +diff --git a/system/vl.c b/system/vl.c +index 0dbdba6421..67822c6b6c 100644 +--- a/system/vl.c ++++ b/system/vl.c +@@ -3769,7 +3769,7 @@ void qemu_init(int argc, char **argv) + + machine_class = MACHINE_GET_CLASS(current_machine); + if (!qtest_enabled() && machine_class->deprecation_reason) { +- warn_report("Machine type '%s' is deprecated: %s", ++ info_report("Machine type '%s': %s", + machine_class->name, machine_class->deprecation_reason); + } + diff --git a/debian/patches/series b/debian/patches/series index 0b48878..ffbfd29 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -61,3 +61,4 @@ pve/0048-PVE-backup-fixup-error-handling-for-fleecing.patch pve/0049-PVE-backup-factor-out-setting-up-snapshot-access-for.patch pve/0050-PVE-backup-save-device-name-in-device-info-structure.patch pve/0051-PVE-backup-include-device-name-in-error-when-setting.patch +pve/0052-weaken-machine-version-deprecation-warning.patch -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel