From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 91BC41FF16F for ; Thu, 2 Jan 2025 13:23:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4A129BE70; Thu, 2 Jan 2025 13:23:33 +0100 (CET) From: Lukas Wagner To: pve-devel@lists.proxmox.com Date: Thu, 2 Jan 2025 13:22:52 +0100 Message-Id: <20250102122252.146567-1-l.wagner@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.141 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] pull metric: fix node iowait metric X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The hash from which we query cpu metrics contains 'iowait' as well as 'wait'. The first one is the total amount of time that was spent waiting on IO, the second one is the percentage of time spent on waiting on IO in a certain time frame. For the metrics returned by the /cluster/metrics/export endpoint we want the second one. Reported-by: Dominik Csapak Signed-off-by: Lukas Wagner --- PVE/PullMetric.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/PullMetric.pm b/PVE/PullMetric.pm index 92f4daef..954bd604 100644 --- a/PVE/PullMetric.pm +++ b/PVE/PullMetric.pm @@ -103,7 +103,7 @@ my sub get_node_metrics { push @$metrics, gauge($id, $timestamp, "cpu_avg15", $cpustat->{avg15}); push @$metrics, gauge($id, $timestamp, "cpu_max", $cpustat->{cpus}); push @$metrics, gauge($id, $timestamp, "cpu_current", $cpustat->{cpu}); - push @$metrics, gauge($id, $timestamp, "cpu_iowait", $cpustat->{iowait}); + push @$metrics, gauge($id, $timestamp, "cpu_iowait", $cpustat->{wait}); my $memory = $data->{memory}; push @$metrics, gauge($id, $timestamp, "mem_total", $memory->{memtotal}); -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel