From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 359141FF164 for ; Fri, 20 Dec 2024 19:53:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 45327C367; Fri, 20 Dec 2024 19:53:00 +0100 (CET) From: Max Carrara To: pve-devel@lists.proxmox.com Date: Fri, 20 Dec 2024 19:52:03 +0100 Message-Id: <20241220185207.519912-9-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241220185207.519912-1-m.carrara@proxmox.com> References: <20241220185207.519912-1-m.carrara@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.042 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 pve-common 08/12] test: add tests for path_starts_with, path_ends_with, path_equals X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" .. of PVE::Path. Each function has its test cases defined separately to avoid running unnecessary tests / repeating equivalent tests for certain things. Signed-off-by: Max Carrara --- Changes v1 --> v2: * NEW: Split from patch 02 test/Path/Makefile | 1 + test/Path/path_comparison_tests.pl | 851 +++++++++++++++++++++++++++++ 2 files changed, 852 insertions(+) create mode 100755 test/Path/path_comparison_tests.pl diff --git a/test/Path/Makefile b/test/Path/Makefile index a2b5bb1..627dc09 100644 --- a/test/Path/Makefile +++ b/test/Path/Makefile @@ -1,4 +1,5 @@ TESTS = \ + path_comparison_tests.pl \ path_components_tests.pl \ path_is_absolute_relative_tests.pl \ path_join_tests.pl \ diff --git a/test/Path/path_comparison_tests.pl b/test/Path/path_comparison_tests.pl new file mode 100755 index 0000000..928edc1 --- /dev/null +++ b/test/Path/path_comparison_tests.pl @@ -0,0 +1,851 @@ +#!/usr/bin/env perl + +use lib '../../src'; + +use strict; +use warnings; + +use Test::More; + +use PVE::Path; + +my $path_starts_with_cases = [ + { + name => "empty path starts with empty path", + path => "", + other_path => "", + expected => 1, + }, + { + name => "root starts with empty path", + path => "/", + other_path => "", + expected => undef, + }, + { + name => "empty path starts with root", + path => "", + other_path => "/", + expected => undef, + }, + { + name => "foo starts with foo", + path => "foo", + other_path => "foo", + expected => 1, + }, + { + name => "foo/ starts with foo", + path => "foo/", + other_path => "foo", + expected => 1, + }, + { + name => "foo starts with foo/", + path => "foo", + other_path => "foo/", + expected => 1, + }, + { + name => "foo/ starts with foo/", + path => "foo/", + other_path => "foo/", + expected => 1, + }, + { + name => "foo starts with bar", + path => "foo", + other_path => "bar", + expected => undef, + }, + { + name => "foo/ starts with bar", + path => "foo/", + other_path => "bar", + expected => undef, + }, + { + name => "foo starts with bar/", + path => "foo", + other_path => "bar/", + expected => undef, + }, + { + name => "foo/ starts with bar/", + path => "foo/", + other_path => "bar/", + expected => undef, + }, + { + name => "/foo starts with /", + path => "/foo", + other_path => "/", + expected => 1, + }, + { + name => "/foo starts with /foo", + path => "/foo", + other_path => "/foo", + expected => 1, + }, + { + name => "/foo starts with foo", + path => "/foo", + other_path => "foo", + expected => undef, + }, + { + name => "foo/bar starts with foo", + path => "foo/bar", + other_path => "foo", + expected => 1, + }, + { + name => "foo/bar starts with foo/bar", + path => "foo/bar", + other_path => "foo/bar", + expected => 1, + }, + { + name => "foo/bar starts with foo/bar/", + path => "foo/bar", + other_path => "foo/bar/", + expected => 1, + }, + { + name => "foo/bar/ starts with foo/bar", + path => "foo/bar/", + other_path => "foo/bar", + expected => 1, + }, + { + name => "foo/bar/ starts with foo/bar/", + path => "foo/bar/", + other_path => "foo/bar/", + expected => 1, + }, + { + name => "/foo/bar starts with /foo", + path => "/foo/bar", + other_path => "/foo", + expected => 1, + }, + { + name => "/foo/bar starts with /foo/bar", + path => "/foo/bar", + other_path => "/foo/bar", + expected => 1, + }, + { + name => "/foo/bar/ starts with /foo/bar", + path => "/foo/bar/", + other_path => "/foo/bar", + expected => 1, + }, + { + name => "/foo/bar starts with /foo/bar/", + path => "/foo/bar", + other_path => "/foo/bar/", + expected => 1, + }, + { + name => "/foo/bar/ starts with /foo/bar/", + path => "/foo/bar/", + other_path => "/foo/bar/", + expected => 1, + }, + { + name => "foo/bar/baz/quo/qux starts with foo/bar/baz/quo", + path => "foo/bar/baz/quo/qux", + other_path => "foo/bar/baz/quo", + expected => 1, + }, + { + name => "/foo/bar/baz/quo/qux starts with /foo/bar/baz/quo", + path => "/foo/bar/baz/quo/qux", + other_path => "/foo/bar/baz/quo", + expected => 1, + }, + { + name => "foo/bar/baz/quo/qux starts with one/two/three", + path => "foo/bar/baz/quo/qux", + other_path => "one/two/three", + expected => undef, + }, + { + name => "/foo/bar/baz/quo/qux starts with /one/two/three", + path => "/foo/bar/baz/quo/qux", + other_path => "/one/two/three", + expected => undef, + }, + { + name => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw" + . " starts with /etc/pve", + path => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw", + other_path => "/etc/pve", + expected => 1, + }, + { + name => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw" + . " starts with /etc/pve/firewall/cluster.fw", + path => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw", + other_path => "/etc/pve/firewall/cluster.fw", + expected => 1, + }, + { + name => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw" + . " starts with" + . " ///etc/////././././////pve//./././firewall/.//././././././././///cluster.fw", + path => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw", + other_path => "///etc/////././././////pve//./././firewall/.//././././././././///cluster.fw", + expected => 1, + }, + { + name => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw" + . " starts with /etc/ceph", + path => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw", + other_path => "/etc/ceph", + expected => undef, + }, + { + name => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw" + . " starts with /etc/pve/firewall/cluster.fw.gz", + path => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw", + other_path => "/etc/pve/firewall/cluster.fw.gz", + expected => undef, + }, + { + name => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw" + . " starts with" + . " ///etc/////././././////pve/oh/no/./././firewall/.//././././././././///cluster.fw", + path => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw", + other_path => "///etc/////././././////pve/oh/no/./././firewall/.//././././././././///cluster.fw", + expected => undef, + }, + { + name => "foo/../bar starts with foo/..", + path => "foo/../bar", + other_path => "foo/..", + expected => 1, + }, + { + name => "foo/./bar starts with foo/bar", + path => "foo/./bar", + other_path => "foo/bar", + expected => 1, + }, +]; + +sub test_path_starts_with : prototype($) { + my ($case) = @_; + + my $name = "path_starts_with: " . $case->{name}; + + my $result = eval { + PVE::Path::path_starts_with($case->{path}, $case->{other_path}); + }; + + if ($@) { + if ($case->{should_throw}) { + pass($name); + return; + } + + fail($name); + diag("Encountered exception while running path_starts_with():\n$@"); + return; + } + + if (!is($result, $case->{expected}, $name)) { + diag("path = " . $case->{path}); + diag(" (" . join(", ", PVE::Path::path_components($case->{path})) . ")"); + diag("other_path = " . $case->{other_path}); + diag(" (" . join(", ", PVE::Path::path_components($case->{other_path})) . ")"); + } + + return; +} + +my $path_ends_with_cases = [ + { + name => "empty path ends with empty path", + path => "", + other_path => "", + expected => 1, + }, + { + name => "root ends with empty path", + path => "/", + other_path => "", + expected => undef, + }, + { + name => "empty path ends with root", + path => "", + other_path => "/", + expected => undef, + }, + { + name => "foo ends with foo", + path => "foo", + other_path => "foo", + expected => 1, + }, + { + name => "foo/ ends with foo", + path => "foo/", + other_path => "foo", + expected => 1, + }, + { + name => "foo ends with foo/", + path => "foo", + other_path => "foo/", + expected => 1, + }, + { + name => "foo/ ends with foo/", + path => "foo/", + other_path => "foo/", + expected => 1, + }, + { + name => "foo ends with bar", + path => "foo", + other_path => "bar", + expected => undef, + }, + { + name => "foo/ ends with bar", + path => "foo/", + other_path => "bar", + expected => undef, + }, + { + name => "foo ends with bar/", + path => "foo", + other_path => "bar/", + expected => undef, + }, + { + name => "foo/ ends with bar/", + path => "foo/", + other_path => "bar/", + expected => undef, + }, + { + name => "/foo ends with /", + path => "/foo", + other_path => "/", + expected => undef, + }, + { + name => "/foo ends with /foo", + path => "/foo", + other_path => "/foo", + expected => 1, + }, + { + name => "/foo ends with foo", + path => "/foo", + other_path => "foo", + expected => 1, + }, + { + name => "foo/bar ends with foo", + path => "foo/bar", + other_path => "foo", + expected => undef, + }, + { + name => "foo/bar ends with bar", + path => "foo/bar", + other_path => "bar", + expected => 1, + }, + { + name => "foo/bar ends with foo/bar", + path => "foo/bar", + other_path => "foo/bar", + expected => 1, + }, + { + name => "foo/bar ends with foo/bar/", + path => "foo/bar", + other_path => "foo/bar/", + expected => 1, + }, + { + name => "foo/bar/ ends with foo/bar", + path => "foo/bar/", + other_path => "foo/bar", + expected => 1, + }, + { + name => "foo/bar/ ends with foo/bar/", + path => "foo/bar/", + other_path => "foo/bar/", + expected => 1, + }, + { + name => "/foo/bar ends with /foo", + path => "/foo/bar", + other_path => "/foo", + expected => undef, + }, + { + name => "/foo/bar ends with /foo/bar", + path => "/foo/bar", + other_path => "/foo/bar", + expected => 1, + }, + { + name => "/foo/bar/ ends with /foo/bar", + path => "/foo/bar/", + other_path => "/foo/bar", + expected => 1, + }, + { + name => "/foo/bar ends with /foo/bar/", + path => "/foo/bar", + other_path => "/foo/bar/", + expected => 1, + }, + { + name => "/foo/bar/ ends with /foo/bar/", + path => "/foo/bar/", + other_path => "/foo/bar/", + expected => 1, + }, + { + name => "foo/bar/baz/quo/qux ends with bar/baz/quo/qux", + path => "foo/bar/baz/quo/qux", + other_path => "bar/baz/quo/qux", + expected => 1, + }, + { + name => "/foo/bar/baz/quo/qux ends with bar/baz/quo/qux", + path => "/foo/bar/baz/quo/qux", + other_path => "bar/baz/quo/qux", + expected => 1, + }, + { + name => "foo/bar/baz/quo/qux ends with one/two/three", + path => "foo/bar/baz/quo/qux", + other_path => "one/two/three", + expected => undef, + }, + { + name => "/foo/bar/baz/quo/qux ends with /one/two/three", + path => "/foo/bar/baz/quo/qux", + other_path => "/one/two/three", + expected => undef, + }, + { + name => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw" + . " ends with firewall/cluster.fw", + path => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw", + other_path => "firewall/cluster.fw", + expected => 1, + }, + { + name => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw" + . " ends with /etc/pve/firewall/cluster.fw", + path => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw", + other_path => "/etc/pve/firewall/cluster.fw", + expected => 1, + }, + { + name => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw" + . " ends with" + . " ///etc/////././././////pve//./././firewall/.//././././././././///cluster.fw", + path => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw", + other_path => "///etc/////././././////pve//./././firewall/.//././././././././///cluster.fw", + expected => 1, + }, + { + name => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw" + . " ends with firewall/cluster.fw.gz", + path => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw", + other_path => "firewall/cluster.fw.gz", + expected => undef, + }, + { + name => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw" + . " ends with /etc/pve/firewall/cluster.fw.gz", + path => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw", + other_path => "/etc/pve/firewall/cluster.fw.gz", + expected => undef, + }, + { + name => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw" + . " ends with" + . " ///etc/////././././////pve/oh/no/./././firewall/.//././././././././///cluster.fw", + path => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw", + other_path => "///etc/////././././////pve/oh/no/./././firewall/.//././././././././///cluster.fw", + expected => undef, + }, + { + name => "foo/../bar ends with ../bar", + path => "foo/../bar", + other_path => "../bar", + expected => 1, + }, + { + name => "foo/./bar ends with foo/bar", + path => "foo/./bar", + other_path => "foo/bar", + expected => 1, + }, +]; + +sub test_path_ends_with : prototype($) { + my ($case) = @_; + + my $name = "path_ends_with: " . $case->{name}; + + my $result = eval { + PVE::Path::path_ends_with($case->{path}, $case->{other_path}); + }; + + if ($@) { + if ($case->{should_throw}) { + pass($name); + return; + } + + fail($name); + diag("Encountered exception while running path_ends_with():\n$@"); + return; + } + + if (!is($result, $case->{expected}, $name)) { + diag("path = " . $case->{path}); + diag(" (" . join(", ", PVE::Path::path_components($case->{path})) . ")"); + diag("other_path = " . $case->{other_path}); + diag(" (" . join(", ", PVE::Path::path_components($case->{other_path})) . ")"); + } + + return; +} + +my $path_equals_cases = [ + { + name => "empty path equals empty path", + path => "", + other_path => "", + expected => 1, + }, + { + name => "root equals empty path", + path => "/", + other_path => "", + expected => undef, + }, + { + name => "empty path equals root", + path => "", + other_path => "/", + expected => undef, + }, + { + name => "foo equals foo", + path => "foo", + other_path => "foo", + expected => 1, + }, + { + name => "foo/ equals foo", + path => "foo/", + other_path => "foo", + expected => 1, + }, + { + name => "foo equals foo/", + path => "foo", + other_path => "foo/", + expected => 1, + }, + { + name => "foo/ equals foo/", + path => "foo/", + other_path => "foo/", + expected => 1, + }, + { + name => "foo equals bar", + path => "foo", + other_path => "bar", + expected => undef, + }, + { + name => "foo/ equals bar", + path => "foo/", + other_path => "bar", + expected => undef, + }, + { + name => "foo equals bar/", + path => "foo", + other_path => "bar/", + expected => undef, + }, + { + name => "foo/ equals bar/", + path => "foo/", + other_path => "bar/", + expected => undef, + }, + { + name => "/foo equals /", + path => "/foo", + other_path => "/", + expected => undef, + }, + { + name => "/foo equals /foo", + path => "/foo", + other_path => "/foo", + expected => 1, + }, + { + name => "/foo equals foo", + path => "/foo", + other_path => "foo", + expected => undef, + }, + { + name => "foo/bar equals foo", + path => "foo/bar", + other_path => "foo", + expected => undef, + }, + { + name => "foo/bar equals bar", + path => "foo/bar", + other_path => "bar", + expected => undef, + }, + { + name => "foo/bar equals foo/bar", + path => "foo/bar", + other_path => "foo/bar", + expected => 1, + }, + { + name => "foo/bar equals foo/bar/", + path => "foo/bar", + other_path => "foo/bar/", + expected => 1, + }, + { + name => "foo/bar/ equals foo/bar", + path => "foo/bar/", + other_path => "foo/bar", + expected => 1, + }, + { + name => "foo/bar/ equals foo/bar/", + path => "foo/bar/", + other_path => "foo/bar/", + expected => 1, + }, + { + name => "/foo/bar equals /foo", + path => "/foo/bar", + other_path => "/foo", + expected => undef, + }, + { + name => "/foo/bar equals /foo/bar", + path => "/foo/bar", + other_path => "/foo/bar", + expected => 1, + }, + { + name => "/foo/bar/ equals /foo/bar", + path => "/foo/bar/", + other_path => "/foo/bar", + expected => 1, + }, + { + name => "/foo/bar equals /foo/bar/", + path => "/foo/bar", + other_path => "/foo/bar/", + expected => 1, + }, + { + name => "/foo/bar/ equals /foo/bar/", + path => "/foo/bar/", + other_path => "/foo/bar/", + expected => 1, + }, + { + name => "foo/bar/baz/quo/qux equals foo/bar/baz/quo/qux", + path => "foo/bar/baz/quo/qux", + other_path => "foo/bar/baz/quo/qux", + expected => 1, + }, + { + name => "/foo/bar/baz/quo/qux equals /foo/bar/baz/quo/qux", + path => "/foo/bar/baz/quo/qux", + other_path => "/foo/bar/baz/quo/qux", + expected => 1, + }, + { + name => "/foo/bar/baz/quo/qux equals foo/bar/baz/quo/qux", + path => "/foo/bar/baz/quo/qux", + other_path => "foo/bar/baz/quo/qux", + expected => undef, + }, + { + name => "foo/bar/baz/quo/qux equals one/two/three", + path => "foo/bar/baz/quo/qux", + other_path => "one/two/three", + expected => undef, + }, + { + name => "/foo/bar/baz/quo/qux equals /one/two/three", + path => "/foo/bar/baz/quo/qux", + other_path => "/one/two/three", + expected => undef, + }, + { + name => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw" + . " equals /etc/pve", + path => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw", + other_path => "/etc/pve", + expected => undef, + }, + { + name => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw" + . " equals firewall/cluster.fw", + path => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw", + other_path => "firewall/cluster.fw", + expected => undef, + }, + { + name => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw" + . " equals /etc/pve/firewall/cluster.fw", + path => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw", + other_path => "/etc/pve/firewall/cluster.fw", + expected => 1, + }, + { + name => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw" + . " equals" + . " ///etc/////././././////pve//./././firewall/.//././././././././///cluster.fw", + path => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw", + other_path => "///etc/////././././////pve//./././firewall/.//././././././././///cluster.fw", + expected => 1, + }, + { + name => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw" + . " equals firewall/cluster.fw.gz", + path => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw", + other_path => "firewall/cluster.fw.gz", + expected => undef, + }, + { + name => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw" + . " equals /etc/pve/firewall/cluster.fw.gz", + path => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw", + other_path => "/etc/pve/firewall/cluster.fw.gz", + expected => undef, + }, + { + name => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw" + . " equals" + . " ///etc/////././././////pve/oh/no/./././firewall/.//././././././././///cluster.fw", + path => "//./././///././//etc/.//./pve/././//.//firewall/././cluster.fw", + other_path => "///etc/////././././////pve/oh/no/./././firewall/.//././././././././///cluster.fw", + expected => undef, + }, + { + name => "foo/../bar equals foo/..", + path => "foo/../bar", + other_path => "foo/..", + expected => undef, + }, + { + name => "foo/../bar equals ../bar", + path => "foo/../bar", + other_path => "../bar", + expected => undef, + }, + { + name => "foo/./bar equals foo/bar", + path => "foo/./bar", + other_path => "foo/bar", + expected => 1, + }, +]; + +sub test_path_equals : prototype($) { + my ($case) = @_; + + my $name = "path_equals: " . $case->{name}; + + my $result = eval { + PVE::Path::path_equals($case->{path}, $case->{other_path}); + }; + + if ($@) { + if ($case->{should_throw}) { + pass($name); + return; + } + + fail($name); + diag("Encountered exception while running path_equals():\n$@"); + return; + } + + if (!is($result, $case->{expected}, $name)) { + diag("path = " . $case->{path}); + diag(" (" . join(", ", PVE::Path::path_components($case->{path})) . ")"); + diag("other_path = " . $case->{other_path}); + diag(" (" . join(", ", PVE::Path::path_components($case->{other_path})) . ")"); + } + + return; +} + +sub main : prototype() { + plan( + tests => scalar($path_starts_with_cases->@*) + + scalar($path_ends_with_cases->@*) + + scalar($path_equals_cases->@*) + ); + + for my $case ($path_starts_with_cases->@*) { + eval { + # suppress warnings here to make output less noisy for certain tests if necessary + # local $SIG{__WARN__} = sub {}; + test_path_starts_with($case); + }; + warn "$@\n" if $@; + } + + for my $case ($path_ends_with_cases->@*) { + eval { + # local $SIG{__WARN__} = sub {}; + test_path_ends_with($case); + }; + warn "$@\n" if $@; + } + + for my $case ($path_equals_cases->@*) { + eval { + # local $SIG{__WARN__} = sub {}; + test_path_equals($case); + }; + warn "$@\n" if $@; + } + + done_testing(); + + return; +} + +main(); -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel