From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 797B41FF164 for ; Fri, 20 Dec 2024 19:53:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 04B93C2D4; Fri, 20 Dec 2024 19:52:53 +0100 (CET) From: Max Carrara To: pve-devel@lists.proxmox.com Date: Fri, 20 Dec 2024 19:52:01 +0100 Message-Id: <20241220185207.519912-7-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241220185207.519912-1-m.carrara@proxmox.com> References: <20241220185207.519912-1-m.carrara@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.042 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 pve-common 06/12] test: add tests for path_push of PVE::Path X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Signed-off-by: Max Carrara --- Changes v1 --> v2: * NEW: Split from patch 02 test/Path/Makefile | 1 + test/Path/path_push_tests.pl | 159 +++++++++++++++++++++++++++++++++++ 2 files changed, 160 insertions(+) create mode 100755 test/Path/path_push_tests.pl diff --git a/test/Path/Makefile b/test/Path/Makefile index 08d34ac..9dd95f1 100644 --- a/test/Path/Makefile +++ b/test/Path/Makefile @@ -2,6 +2,7 @@ TESTS = \ path_components_tests.pl \ path_is_absolute_relative_tests.pl \ path_join_tests.pl \ + path_push_tests.pl \ TEST_TARGETS = $(addsuffix .t,$(basename ${TESTS})) diff --git a/test/Path/path_push_tests.pl b/test/Path/path_push_tests.pl new file mode 100755 index 0000000..3b006a0 --- /dev/null +++ b/test/Path/path_push_tests.pl @@ -0,0 +1,159 @@ +#!/usr/bin/env perl + +use lib '../../src'; + +use strict; +use warnings; + +use Test::More; + +use PVE::Path; + +my $cases = [ + { + name => "push empty onto empty path", + path => "", + to_push => "", + pushed => "", + }, + { + name => "push empty onto root", + path => "/", + to_push => "", + pushed => "/", + }, + { + name => "push single component onto empty path", + path => "", + to_push => "foo", + pushed => "foo", + }, + { + name => "push single component onto root", + path => "/", + to_push => "foo", + pushed => "/foo", + }, + { + name => "push single component onto single component", + path => "foo", + to_push => "bar", + pushed => "foo/bar", + }, + { + name => "push single component onto single component with trailing slash", + path => "foo/", + to_push => "bar", + pushed => "foo/bar", + }, + { + name => "push single component with trailing slath onto single component", + path => "foo", + to_push => "bar/", + pushed => "foo/bar/", + }, + { + name => "push single component with trailing slash" + . " onto single component with trailing slash", + path => "foo/", + to_push => "bar/", + pushed => "foo/bar/", + }, + { + name => "push relative path onto relative path", + path => "foo/bar", + to_push => "baz/quo", + pushed => "foo/bar/baz/quo", + }, + { + name => "push relative path onto relative path with trailing slash", + path => "foo/bar/", + to_push => "baz/quo", + pushed => "foo/bar/baz/quo", + }, + { + name => "push relative path with trailing slash onto relative path", + path => "foo/bar", + to_push => "baz/quo/", + pushed => "foo/bar/baz/quo/", + }, + { + name => "push relative path with trailing slash onto relative path with trailing slash", + path => "foo/bar/", + to_push => "baz/quo/", + pushed => "foo/bar/baz/quo/", + }, + { + name => "push root onto relative path", + path => "foo/bar", + to_push => "/", + pushed => "/", + }, + { + name => "push root onto absolute path", + path => "/foo/bar", + to_push => "/", + pushed => "/", + }, + { + name => "push absolute path onto relative path", + path => "foo/bar", + to_push => "/baz/quo", + pushed => "/baz/quo", + }, + { + name => "push absolute path onto absolute path", + path => "/foo/bar", + to_push => "/baz/quo", + pushed => "/baz/quo", + }, +]; + +sub test_path_push : prototype($) { + my ($case) = @_; + + my $name = "path_push: " . $case->{name}; + + my $pushed = eval { PVE::Path::path_push($case->{path}, $case->{to_push}); }; + + if ($@) { + fail($name); + diag("Failed to push onto path:\n$@"); + return; + } + + if (!is($pushed, $case->{pushed}, $name)) { + diag("=== Expected ==="); + diag(explain($case->{pushed})); + diag("=== Got ==="); + diag(explain($pushed)); + } + + return; +} + + +sub main : prototype() { + my $test_subs = [ + \&test_path_push, + ]; + + plan(tests => scalar($cases->@*) * scalar($test_subs->@*)); + + for my $case ($cases->@*) { + for my $test_sub ($test_subs->@*) { + eval { + # suppress warnings here to make output less noisy for certain tests if necessary + # local $SIG{__WARN__} = sub {}; + $test_sub->($case); + }; + warn "$@\n" if $@; + } + } + + done_testing(); + + return; +} + +main(); -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel