public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH container 1/2] migration: allow rbd storages for remote migration
@ 2024-12-18 10:32 Fiona Ebner
  2024-12-18 10:32 ` [pve-devel] [PATCH container 2/2] migration: add reminder to evaluate dropping seemingly useless check for PVE 9 Fiona Ebner
  2024-12-18 14:21 ` [pve-devel] [PATCH container 1/2] migration: allow rbd storages for remote migration Daniel Kral
  0 siblings, 2 replies; 6+ messages in thread
From: Fiona Ebner @ 2024-12-18 10:32 UTC (permalink / raw)
  To: pve-devel

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

This is a follow-up for:
https://lore.proxmox.com/pve-devel/20241217154814.82121-1-f.ebner@proxmox.com/T/#m669d0a02ebf10ab54ad18f27589902ee0b2cbace

 src/PVE/LXC/Migrate.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm
index 0debb9e..e1e6cab 100644
--- a/src/PVE/LXC/Migrate.pm
+++ b/src/PVE/LXC/Migrate.pm
@@ -303,6 +303,7 @@ sub phase1 {
 	    if ($remote) {
 		push @$migratable_storages, 'cifs';
 		push @$migratable_storages, 'nfs';
+		push @$migratable_storages, 'rbd';
 	    }
 
 	    die "storage type '$scfg->{type}' not supported\n"
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [pve-devel] [PATCH container 2/2] migration: add reminder to evaluate dropping seemingly useless check for PVE 9
  2024-12-18 10:32 [pve-devel] [PATCH container 1/2] migration: allow rbd storages for remote migration Fiona Ebner
@ 2024-12-18 10:32 ` Fiona Ebner
  2025-02-10 16:12   ` [pve-devel] applied: " Thomas Lamprecht
  2024-12-18 14:21 ` [pve-devel] [PATCH container 1/2] migration: allow rbd storages for remote migration Daniel Kral
  1 sibling, 1 reply; 6+ messages in thread
From: Fiona Ebner @ 2024-12-18 10:32 UTC (permalink / raw)
  To: pve-devel

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/LXC/Migrate.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm
index e1e6cab..a550d70 100644
--- a/src/PVE/LXC/Migrate.pm
+++ b/src/PVE/LXC/Migrate.pm
@@ -292,6 +292,8 @@ sub phase1 {
 	    my ($sid, $volname) = PVE::Storage::parse_volume_id($volid);
 	    my $scfg =  PVE::Storage::storage_config($self->{storecfg}, $sid);
 
+	    # FIXME PVE 9 - why is this even here, can't it just be dropped completely? The storage
+	    # layer already dies if there is no valid transport format.
 	    # TODO move to storage plugin layer?
 	    my $migratable_storages = [
 		'dir',
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [pve-devel] [PATCH container 1/2] migration: allow rbd storages for remote migration
  2024-12-18 10:32 [pve-devel] [PATCH container 1/2] migration: allow rbd storages for remote migration Fiona Ebner
  2024-12-18 10:32 ` [pve-devel] [PATCH container 2/2] migration: add reminder to evaluate dropping seemingly useless check for PVE 9 Fiona Ebner
@ 2024-12-18 14:21 ` Daniel Kral
  1 sibling, 0 replies; 6+ messages in thread
From: Daniel Kral @ 2024-12-18 14:21 UTC (permalink / raw)
  To: pve-devel

On 12/18/24 11:32, Fiona Ebner wrote:
> [ ... ]
> --- a/src/PVE/LXC/Migrate.pm
> +++ b/src/PVE/LXC/Migrate.pm
> @@ -303,6 +303,7 @@ sub phase1 {
>   	    if ($remote) {
>   		push @$migratable_storages, 'cifs';
>   		push @$migratable_storages, 'nfs';
> +		push @$migratable_storages, 'rbd';
>   	    }
>   
>   	    die "storage type '$scfg->{type}' not supported\n"

Works as expected, without this patch the remote migration fails. When 
applied, containers stored on rbd storages are also allowed.

Tested-by: Daniel Kral <d.kral@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [pve-devel] applied: [PATCH container 2/2] migration: add reminder to evaluate dropping seemingly useless check for PVE 9
  2024-12-18 10:32 ` [pve-devel] [PATCH container 2/2] migration: add reminder to evaluate dropping seemingly useless check for PVE 9 Fiona Ebner
@ 2025-02-10 16:12   ` Thomas Lamprecht
  2025-02-11  9:45     ` Fiona Ebner
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Lamprecht @ 2025-02-10 16:12 UTC (permalink / raw)
  To: Proxmox VE development discussion, Fiona Ebner

Am 18.12.24 um 11:32 schrieb Fiona Ebner:
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  src/PVE/LXC/Migrate.pm | 2 ++
>  1 file changed, 2 insertions(+)
> 
>

applied, thanks!

The first patch was already applied by Fabian on 2024-12-19:

https://git.proxmox.com/?p=pve-container.git;a=commit;h=a257aa44969e0775f8b31ff729f7ad591bd304b9


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [pve-devel] applied: [PATCH container 2/2] migration: add reminder to evaluate dropping seemingly useless check for PVE 9
  2025-02-10 16:12   ` [pve-devel] applied: " Thomas Lamprecht
@ 2025-02-11  9:45     ` Fiona Ebner
  2025-02-11  9:51       ` Thomas Lamprecht
  0 siblings, 1 reply; 6+ messages in thread
From: Fiona Ebner @ 2025-02-11  9:45 UTC (permalink / raw)
  To: Thomas Lamprecht, Proxmox VE development discussion

Am 10.02.25 um 17:12 schrieb Thomas Lamprecht:
> Am 18.12.24 um 11:32 schrieb Fiona Ebner:
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>>  src/PVE/LXC/Migrate.pm | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>>
> 
> applied, thanks!
> 
> The first patch was already applied by Fabian on 2024-12-19:
> 
> https://git.proxmox.com/?p=pve-container.git;a=commit;h=a257aa44969e0775f8b31ff729f7ad591bd304b9

Fabian told me (off-list, well...) that it's still useful as an early
check and that makes sense. I guess it can be improved by querying the
transport formats for all disks early via the storage layer proper, but
the check should not be dropped completely. And IIRC, VM migration is
currently missing such an early check.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [pve-devel] applied: [PATCH container 2/2] migration: add reminder to evaluate dropping seemingly useless check for PVE 9
  2025-02-11  9:45     ` Fiona Ebner
@ 2025-02-11  9:51       ` Thomas Lamprecht
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Lamprecht @ 2025-02-11  9:51 UTC (permalink / raw)
  To: Fiona Ebner, Proxmox VE development discussion

Am 11.02.25 um 10:45 schrieb Fiona Ebner:
> Am 10.02.25 um 17:12 schrieb Thomas Lamprecht:
>> Am 18.12.24 um 11:32 schrieb Fiona Ebner:
>>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>>> ---
>>>  src/PVE/LXC/Migrate.pm | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>>
>>
>> applied, thanks!
>>
>> The first patch was already applied by Fabian on 2024-12-19:
>>
>> https://git.proxmox.com/?p=pve-container.git;a=commit;h=a257aa44969e0775f8b31ff729f7ad591bd304b9
> 
> Fabian told me (off-list, well...) that it's still useful as an early

ah great, neither an applied mail nor a mail with such an outcome stated...

> check and that makes sense. I guess it can be improved by querying the
> transport formats for all disks early via the storage layer proper, but
> the check should not be dropped completely. And IIRC, VM migration is
> currently missing such an early check.

Still thanks for the info, I now pushed a revert of this patch with some
context in the commit message.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-02-11  9:51 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-18 10:32 [pve-devel] [PATCH container 1/2] migration: allow rbd storages for remote migration Fiona Ebner
2024-12-18 10:32 ` [pve-devel] [PATCH container 2/2] migration: add reminder to evaluate dropping seemingly useless check for PVE 9 Fiona Ebner
2025-02-10 16:12   ` [pve-devel] applied: " Thomas Lamprecht
2025-02-11  9:45     ` Fiona Ebner
2025-02-11  9:51       ` Thomas Lamprecht
2024-12-18 14:21 ` [pve-devel] [PATCH container 1/2] migration: allow rbd storages for remote migration Daniel Kral

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal