From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E84F31FF16B for ; Thu, 12 Dec 2024 11:02:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A44441833B; Thu, 12 Dec 2024 11:02:53 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Thu, 12 Dec 2024 11:02:47 +0100 Message-Id: <20241212100247.20926-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241212100247.20926-1-f.ebner@proxmox.com> References: <20241212100247.20926-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server 2/2] qmp client: add default timeouts for more blockdev commands X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" For the HMP 'drive_add' command, the used timeout is 1 minute and for the 'drive_del' command, the used timeout is 10 minutes, because IO might need to be finished. Use the same for 'blockdev-add' respectively 'blockdev-del'. For 'drive-mirror', 10 minutes is used, so use the same for 'blockdev-mirror'. Signed-off-by: Fiona Ebner --- PVE/QMPClient.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/QMPClient.pm b/PVE/QMPClient.pm index b03f1da8..5fa8b815 100644 --- a/PVE/QMPClient.pm +++ b/PVE/QMPClient.pm @@ -119,6 +119,7 @@ sub cmd { # that are executed upon thaw, so use 3 minutes to be on the safe side. $timeout = 3 * 60; } elsif ( + $cmd->{execute} eq 'blockdev-add' || $cmd->{execute} eq 'device_add' || $cmd->{execute} eq 'device_del' || $cmd->{execute} eq 'netdev_add' || @@ -129,6 +130,8 @@ sub cmd { $timeout = 60; } elsif ( $cmd->{execute} eq 'backup-cancel' || + $cmd->{execute} eq 'blockdev-del' || + $cmd->{execute} eq 'blockdev-mirror' || $cmd->{execute} eq 'blockdev-snapshot-delete-internal-sync' || $cmd->{execute} eq 'blockdev-snapshot-internal-sync' || $cmd->{execute} eq 'block-job-cancel' || -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel