From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C90F61FF164 for <inbox@lore.proxmox.com>; Fri, 6 Dec 2024 12:20:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DDD0C3E2F; Fri, 6 Dec 2024 12:20:34 +0100 (CET) From: Gabriel Goller <g.goller@proxmox.com> To: pve-devel@lists.proxmox.com Date: Fri, 6 Dec 2024 12:19:54 +0100 Message-Id: <20241206111958.117362-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.035 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH cluster/docs/manager/widget-toolkit v2 0/4] fix #5463: add optional Consent Banner on login X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> The consent text is stored in the datacenter.cfg file and is encoded using base64. This allows us to support multi-line strings and special characters. To easily edit the text the existing edit-field ProxmoxTextAreaField is used. It supports editing and saving multi-line text and converting it to its base64 representation. This is the port from the initial PBS implementation and should work in the same way. v2, thanks @Thomas: - limit max characters for consent-text (24000) - wrap datacenter config read in eval - fix js indentation - remove Ext.htmlEncode (this is done by Markdown.parse) manager: Gabriel Goller (1): show optional consent-banner before login PVE/Service/pveproxy.pm | 13 ++++++++++--- www/index.html.tpl | 3 ++- www/manager6/dc/OptionView.js | 8 ++++++++ www/manager6/window/LoginWindow.js | 12 +++++++++++- 4 files changed, 31 insertions(+), 5 deletions(-) cluster: Gabriel Goller (1): add consent-text parameter to datacenter config file src/PVE/DataCenterConfig.pm | 5 +++++ 1 file changed, 5 insertions(+) docs: Gabriel Goller (1): add consent-banner description pve-gui.adoc | 9 +++++++++ 1 file changed, 9 insertions(+) widget-toolkit: Gabriel Goller (1): form: set enforceMaxLength on textareafield src/form/TextAreaField.js | 1 + 1 file changed, 1 insertion(+) Summary over all repositories: 7 files changed, 46 insertions(+), 5 deletions(-) -- Generated by git-murpp 0.7.1 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel