From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 463F51FF163 for ; Thu, 5 Dec 2024 17:34:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E55471EBFC; Thu, 5 Dec 2024 17:34:31 +0100 (CET) From: Daniel Herzig To: pve-devel@lists.proxmox.com Date: Thu, 5 Dec 2024 17:33:31 +0100 Message-Id: <20241205163332.130930-4-d.herzig@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241205163332.130930-1-d.herzig@proxmox.com> References: <20241205163332.130930-1-d.herzig@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH container 3/4] fix #5900: do not create container if dhcp range is exhausted X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This patch prevents containers to be created if their bridge is associated with a SDN zone with dnsmasq automatic dhcp enabled, and if the dhcp-range is exhausted or unset. Signed-off-by: Daniel Herzig --- src/PVE/API2/LXC.pm | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 213e518..35fb0a6 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -244,6 +244,18 @@ __PACKAGE__->register_method({ PVE::LXC::Config->check_protection($conf, "unable to restore CT $vmid"); } + for my $opt (keys %$param) { + if ($opt =~ /net/) { + my $bridge_err; + my $bridge = PVE::GuestHelpers::get_bridge(${param}->{$opt}); + if (defined($bridge)) { + eval { PVE::Network::SDN::Dhcp::test_bridge_for_sdn_dnsmasq($bridge) }; + ${bridge_err}->{$opt} = $@ if $@; + raise_param_exc($bridge_err) if $bridge_err; + } + } + } + my $password = extract_param($param, 'password'); my $ssh_keys = extract_param($param, 'ssh-public-keys'); PVE::Tools::validate_ssh_public_keys($ssh_keys) if defined($ssh_keys); -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel