From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 6F2811FF163
	for <inbox@lore.proxmox.com>; Thu,  5 Dec 2024 13:25:13 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 0CE7B199FD;
	Thu,  5 Dec 2024 13:25:12 +0100 (CET)
From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Thu,  5 Dec 2024 13:23:38 +0100
Message-ID: <20241205122431.1249071-1-c.heiss@proxmox.com>
X-Mailer: git-send-email 2.47.0
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.028 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 FILL_THIS_FORM          0.001 Fill in a form with personal information
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH installer] tree-wide: add workspace-level cargo
 package version
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Means that all CLIs will now have the correct version compiled-in.

This is at least very much relevant for
`proxmox-auto-install-assistant`, which we distribute separately as a
normal binary/package.

Currently, `proxmox-auto-install-assistant --version` always reports
'0.1.0', thus users have to effectively fall back to their system
package manager (if installed via such) to identify the correct version.

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
Of course, that version now also needs to be bumped each time, in
addition to updating d/changelog -- much like it is done for
proxmox-backup.

Just noting it here for the sake of it.

 Cargo.toml                                | 3 +++
 proxmox-auto-install-assistant/Cargo.toml | 2 +-
 proxmox-auto-installer/Cargo.toml         | 2 +-
 proxmox-chroot/Cargo.toml                 | 2 +-
 proxmox-fetch-answer/Cargo.toml           | 2 +-
 proxmox-installer-common/Cargo.toml       | 2 +-
 proxmox-post-hook/Cargo.toml              | 2 +-
 proxmox-tui-installer/Cargo.toml          | 2 +-
 8 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/Cargo.toml b/Cargo.toml
index 8385d58..99b5425 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -10,6 +10,9 @@ members = [
     "proxmox-post-hook",
 ]
 
+[workspace.package]
+version = "8.3.4"
+
 [workspace.dependencies]
 anyhow = "1.0"
 log = "0.4.20"
diff --git a/proxmox-auto-install-assistant/Cargo.toml b/proxmox-auto-install-assistant/Cargo.toml
index 07e6ffb..c5d7b00 100644
--- a/proxmox-auto-install-assistant/Cargo.toml
+++ b/proxmox-auto-install-assistant/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "proxmox-auto-install-assistant"
-version = "0.1.0"
+version.workspace = true
 edition = "2021"
 authors = [
     "Aaron Lauterer <a.lauterer@proxmox.com>",
diff --git a/proxmox-auto-installer/Cargo.toml b/proxmox-auto-installer/Cargo.toml
index d06478f..8940b57 100644
--- a/proxmox-auto-installer/Cargo.toml
+++ b/proxmox-auto-installer/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "proxmox-auto-installer"
-version = "0.1.0"
+version.workspace = true
 edition = "2021"
 authors = [
     "Aaron Lauterer <a.lauterer@proxmox.com>",
diff --git a/proxmox-chroot/Cargo.toml b/proxmox-chroot/Cargo.toml
index 4a27bf7..eab945b 100644
--- a/proxmox-chroot/Cargo.toml
+++ b/proxmox-chroot/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "proxmox-chroot"
-version = "0.1.0"
+version.workspace = true
 edition = "2021"
 authors = [ "Aaron Lauterer <a.lauterer@proxmox.com>" ]
 license = "AGPL-3"
diff --git a/proxmox-fetch-answer/Cargo.toml b/proxmox-fetch-answer/Cargo.toml
index 23bd094..e610807 100644
--- a/proxmox-fetch-answer/Cargo.toml
+++ b/proxmox-fetch-answer/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "proxmox-fetch-answer"
-version = "0.1.0"
+version.workspace = true
 edition = "2021"
 authors = [
     "Aaron Lauterer <a.lauterer@proxmox.com>",
diff --git a/proxmox-installer-common/Cargo.toml b/proxmox-installer-common/Cargo.toml
index b97ccaf..80b3534 100644
--- a/proxmox-installer-common/Cargo.toml
+++ b/proxmox-installer-common/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "proxmox-installer-common"
-version = "0.1.0"
+version.workspace = true
 edition = "2021"
 authors = [ "Aaron Lauterer <a.lauterer@proxmox.com>" ]
 license = "AGPL-3"
diff --git a/proxmox-post-hook/Cargo.toml b/proxmox-post-hook/Cargo.toml
index a2ca206..acf7f9b 100644
--- a/proxmox-post-hook/Cargo.toml
+++ b/proxmox-post-hook/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "proxmox-post-hook"
-version = "0.1.0"
+version.workspace = true
 edition = "2021"
 authors = [
     "Christoph Heiss <c.heiss@proxmox.com>",
diff --git a/proxmox-tui-installer/Cargo.toml b/proxmox-tui-installer/Cargo.toml
index 3db7d73..1f04ce0 100644
--- a/proxmox-tui-installer/Cargo.toml
+++ b/proxmox-tui-installer/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "proxmox-tui-installer"
-version = "0.1.0"
+version.workspace = true
 edition = "2021"
 authors = [ "Christoph Heiss <c.heiss@proxmox.com>" ]
 license = "AGPL-3"
-- 
2.47.0



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel