From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 19A361FF163 for ; Thu, 5 Dec 2024 11:23:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1E7C51799A; Thu, 5 Dec 2024 11:23:54 +0100 (CET) From: Gabriel Goller To: pve-devel@lists.proxmox.com Date: Thu, 5 Dec 2024 11:23:47 +0100 Message-Id: <20241205102348.216706-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.036 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [logger.rs] Subject: [pve-devel] [PATCH v2] log: change default output to stderr and only log errors to journald X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Lukas Wagner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Change the from the pbs logger to the special perlmod logger, which logs every line to stderr and the errors directly to journald. Previously every perlmod output went directly to journald, now it is also visible in the tasklog (through stderr). Reported-by: Maximiliano Sandoval Reported-by: Lukas Wagner Signed-off-by: Gabriel Goller --- v2, thanks @Lukas: - remove unnecessary hunk common/src/logger.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/src/logger.rs b/common/src/logger.rs index 1c8940ba4588..9bae08232d03 100644 --- a/common/src/logger.rs +++ b/common/src/logger.rs @@ -5,7 +5,7 @@ pub fn init(env_var_name: &str, default_log_level: &str) { if let Err(e) = default_log_level .parse() .map_err(Error::from) - .and_then(|default_log_level| proxmox_log::init_logger(env_var_name, default_log_level)) + .and_then(|default_log_level| proxmox_log::init_perlmod_logger(env_var_name, default_log_level)) { eprintln!("could not set up env_logger: {e:?}"); } -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel