From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0F6E11FF161 for ; Wed, 4 Dec 2024 11:30:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 91DC45181; Wed, 4 Dec 2024 11:30:53 +0100 (CET) From: Alexander Zeidler To: pve-devel@lists.proxmox.com Date: Wed, 4 Dec 2024 11:30:03 +0100 Message-Id: <20241204103004.3-2-a.zeidler@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241204103004.3-1-a.zeidler@proxmox.com> References: <20241204103004.3-1-a.zeidler@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.079 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemu.pm] Subject: [pve-devel] [PATCH qemu-server 2/3] api: clone: extend error message by volume ID X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" So far, the error message only contained the name of the disk (tpmstate0, efidisk0, ...), which can also lead to the assumption that a specific disk type is the problem. Now the volume ID is primarily listed. Example: # qm clone 101 102 --full --snapname foo Before: > Full clone feature is not supported for drive 'tpmstate0' After: > Full clone feature is not supported for 'local-zfs:base-100-disk-2/vm-101-disk-2' (tpmstate0) Signed-off-by: Alexander Zeidler --- PVE/API2/Qemu.pm | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index fd08fae0..661cf1e9 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -3899,18 +3899,19 @@ __PACKAGE__->register_method({ if (PVE::QemuServer::drive_is_cdrom($drive, 1)) { $newconf->{$opt} = $value; # simply copy configuration } else { + my $volid = $drive->{file}; if ($full || PVE::QemuServer::drive_is_cloudinit($drive)) { - die "Full clone feature is not supported for drive '$opt'\n" - if !PVE::Storage::volume_has_feature($storecfg, 'copy', $drive->{file}, $snapname, $running); + die "Full clone feature is not supported for '$volid' ($opt)\n" + if !PVE::Storage::volume_has_feature($storecfg, 'copy', $volid, $snapname, $running); $fullclone->{$opt} = 1; } else { # not full means clone instead of copy - die "Linked clone feature is not supported for drive '$opt'\n" - if !PVE::Storage::volume_has_feature($storecfg, 'clone', $drive->{file}, $snapname, $running); + die "Linked clone feature is not supported for '$volid' ($opt)\n" + if !PVE::Storage::volume_has_feature($storecfg, 'clone', $volid, $snapname, $running); } $drives->{$opt} = $drive; next if PVE::QemuServer::drive_is_cloudinit($drive); - push @$vollist, $drive->{file}; + push @$vollist, $volid; } } else { # copy everything else -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel