From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 248991FF170 for ; Tue, 3 Dec 2024 13:24:02 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5AF0430FD; Tue, 3 Dec 2024 13:24:08 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Tue, 3 Dec 2024 13:23:28 +0100 Message-ID: <20241203122331.383398-5-c.heiss@proxmox.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241203122331.383398-1-c.heiss@proxmox.com> References: <20241203122331.383398-1-c.heiss@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [options.rs] Subject: [pve-devel] [PATCH installer 4/4] tui: use pretty_assertions for object equal asserts X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Using the previously introduced `pretty_assertions` crates for object comparisons improves developer UX quite a bit, making failures easier to observe and quickly reason about. Signed-off-by: Christoph Heiss --- proxmox-tui-installer/Cargo.toml | 3 +++ proxmox-tui-installer/src/options.rs | 8 ++++---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/proxmox-tui-installer/Cargo.toml b/proxmox-tui-installer/Cargo.toml index 4b11576..3db7d73 100644 --- a/proxmox-tui-installer/Cargo.toml +++ b/proxmox-tui-installer/Cargo.toml @@ -14,3 +14,6 @@ serde_json.workspace = true regex.workspace = true cursive = { version = "0.21", default-features = false, features = ["crossterm-backend"] } + +[dev-dependencies] +pretty_assertions = "1.4" diff --git a/proxmox-tui-installer/src/options.rs b/proxmox-tui-installer/src/options.rs index b14ecf7..e2116d2 100644 --- a/proxmox-tui-installer/src/options.rs +++ b/proxmox-tui-installer/src/options.rs @@ -144,7 +144,7 @@ mod tests { hostname: Some("foo".to_owned()), }; - assert_eq!( + pretty_assertions::assert_eq!( NetworkOptions::defaults_from(&setup, &info), NetworkOptions { ifname: "eth0".to_owned(), @@ -156,7 +156,7 @@ mod tests { ); info.hostname = None; - assert_eq!( + pretty_assertions::assert_eq!( NetworkOptions::defaults_from(&setup, &info), NetworkOptions { ifname: "eth0".to_owned(), @@ -168,7 +168,7 @@ mod tests { ); info.dns.domain = None; - assert_eq!( + pretty_assertions::assert_eq!( NetworkOptions::defaults_from(&setup, &info), NetworkOptions { ifname: "eth0".to_owned(), @@ -180,7 +180,7 @@ mod tests { ); info.hostname = Some("foo".to_owned()); - assert_eq!( + pretty_assertions::assert_eq!( NetworkOptions::defaults_from(&setup, &info), NetworkOptions { ifname: "eth0".to_owned(), -- 2.47.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel