From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id D710A1FF170 for ; Tue, 3 Dec 2024 13:23:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 05963307E; Tue, 3 Dec 2024 13:23:38 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Tue, 3 Dec 2024 13:23:24 +0100 Message-ID: <20241203122331.383398-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.47.0 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [parse-answer.rs, options.rs] Subject: [pve-devel] [PATCH installer 0/4] auto, tui: improve rust unit test setup X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" First off, it defines all auto-installer "parse answer" tests in a declaratively manner, such that each test actually represent a single rust unit test. Improves developer UX a bit and makes better use of the built-in facilities of `cargo test`. Then it also introduces the `pretty_assertions` crate (as a dev-dependency only, tho) for all object comparison - primarily the answer file parsing/validation tests. This makes failures way easier to observe and quickly reason about. No functional changes in the entire series. Christoph Heiss (4): auto-installer: tests: add tests for raid level case-insensitivity auto-installer: tests: create separate unit test for each answer file auto-installer: tests: add diff'ed assertions for answer parsing tests tui: use pretty_assertions for object equal asserts debian/control | 1 + proxmox-auto-installer/Cargo.toml | 3 + proxmox-auto-installer/tests/parse-answer.rs | 87 +++++++++++-------- .../btrfs_raid_level_uppercase.json | 23 +++++ .../btrfs_raid_level_uppercase.toml | 15 ++++ .../{first-boot.json => first_boot.json} | 0 .../{first-boot.toml => first_boot.toml} | 0 .../zfs_raid_level_uppercase.json | 30 +++++++ .../zfs_raid_level_uppercase.toml | 15 ++++ proxmox-tui-installer/Cargo.toml | 3 + proxmox-tui-installer/src/options.rs | 8 +- 11 files changed, 143 insertions(+), 42 deletions(-) create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/btrfs_raid_level_uppercase.json create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/btrfs_raid_level_uppercase.toml rename proxmox-auto-installer/tests/resources/parse_answer/{first-boot.json => first_boot.json} (100%) rename proxmox-auto-installer/tests/resources/parse_answer/{first-boot.toml => first_boot.toml} (100%) create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/zfs_raid_level_uppercase.json create mode 100644 proxmox-auto-installer/tests/resources/parse_answer/zfs_raid_level_uppercase.toml -- 2.47.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel