From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9AC7B1FF173 for ; Mon, 25 Nov 2024 18:05:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 47E0A19491; Mon, 25 Nov 2024 18:05:23 +0100 (CET) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Mon, 25 Nov 2024 18:04:49 +0100 Message-Id: <20241125170449.238880-2-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241125170449.238880-1-s.hanreich@proxmox.com> References: <20241125170449.238880-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.231 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH proxmox-ve-rs v2 2/2] firewall: alias: document difference between Alias and AliasName X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Alias and AliasName represent two different parts inside a firewall configuration. Document the respective structs better to make the differences between them clearer. Signed-off-by: Stefan Hanreich --- proxmox-ve-config/src/firewall/types/alias.rs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/proxmox-ve-config/src/firewall/types/alias.rs b/proxmox-ve-config/src/firewall/types/alias.rs index 553931e..7d56720 100644 --- a/proxmox-ve-config/src/firewall/types/alias.rs +++ b/proxmox-ve-config/src/firewall/types/alias.rs @@ -35,6 +35,8 @@ impl Display for AliasScope { } } +/// Represents the name of an alias in a firewall rule in the RULES section of the firewall +/// configuration. #[derive(Debug, Clone, DeserializeFromStr, SerializeDisplay)] #[cfg_attr(test, derive(Eq, PartialEq))] pub struct AliasName { @@ -86,6 +88,11 @@ impl AliasName { } } +/// Represents an Alias stored in the ALIASES section of the firewall configuration. +/// +/// Since they contain no scope in the firewall configuration itself, this struct also does not +/// contain a scope. The scope has to be inferred from the Context where this Alias is stored, if +/// that is necessary. #[derive(Debug)] #[cfg_attr(test, derive(Eq, PartialEq))] pub struct Alias { -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel