From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id AF9EC1FF163 for ; Thu, 21 Nov 2024 16:13:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1F4AC6E7; Thu, 21 Nov 2024 16:13:45 +0100 (CET) From: Hannes Laimer To: pve-devel@lists.proxmox.com Date: Thu, 21 Nov 2024 16:13:35 +0100 Message-Id: <20241121151335.130711-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server v2] fix #3588: helper: consider NIC count for config-specific timeout X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" There have been some reports about `qm start` timeouts on VMs that have a lot of NICs assigned. This patch considers the number of NICs when calculating the config-specific timeout. Since the increase in start time is linearly related to the number of NICs, a constant timeout increment per NIC was chosen. Signed-off-by: Hannes Laimer --- v2: thanks @Fiona * fix typo * mention user reports in comment * use scalar * match for `^net\d{1,2}`, not just `^net` PVE/QemuServer/Helpers.pm | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm index 0afb6317..1888487e 100644 --- a/PVE/QemuServer/Helpers.pm +++ b/PVE/QemuServer/Helpers.pm @@ -167,6 +167,15 @@ sub config_aware_timeout { $timeout = 150; } + # Some testing showed that adding a NIC increased the start time by ~450ms + # consistently across different NIC models, options and already existing + # number of NICs. + # So 10x that to account for any potential system differences seemed + # reasonable. User reports with real-life values (20+: ~50s, 25: 45s, 17: 42s) + # also make this seem a good value. + my $nic_count = grep { /^net\d{1,2}/ } keys %{$config}; + $timeout += scalar ($nic_count * 5); + return $timeout; } -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel