From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E00861FF163 for ; Thu, 21 Nov 2024 15:28:05 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2F6E81F275; Thu, 21 Nov 2024 15:28:13 +0100 (CET) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Date: Thu, 21 Nov 2024 15:28:09 +0100 Message-Id: <20241121142809.332913-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.095 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH] webhook edit: do not split translatable strings X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Splitting translatable strings deprives translators for context which might be needed for getting the correct tenses or genders. See [1] for example. [1] https://wiki.gnome.org/TranslationProject(2f)DevGuidelines(2f)Never(20)split(20)sentences.html Signed-off-by: Maximiliano Sandoval --- src/panel/WebhookEditPanel.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/panel/WebhookEditPanel.js b/src/panel/WebhookEditPanel.js index ca99333..9a7b222 100644 --- a/src/panel/WebhookEditPanel.js +++ b/src/panel/WebhookEditPanel.js @@ -70,7 +70,7 @@ Ext.define('Proxmox.panel.WebhookEditPanel', { xtype: 'pmxWebhookKeyValueList', name: 'header', fieldLabel: gettext('Headers'), - subject: gettext('Header'), + addLabel: gettext('Add Header'), maskValues: false, cbind: { isCreate: '{isCreate}', @@ -92,7 +92,7 @@ Ext.define('Proxmox.panel.WebhookEditPanel', { xtype: 'pmxWebhookKeyValueList', name: 'secret', fieldLabel: gettext('Secrets'), - subject: gettext('Secret'), + addLabel: gettext('Add Secret'), maskValues: true, cbind: { isCreate: '{isCreate}', @@ -170,8 +170,8 @@ Ext.define('Proxmox.form.WebhookKeyValueList', { // override for column header fieldTitle: gettext('Item'), - // the text for a single element, used for the add button - subject: undefined, + // label displayed in the "Add" button + addLabel: undefined, // will be applied to the textfields maskRe: undefined, @@ -403,7 +403,7 @@ Ext.define('Proxmox.form.WebhookKeyValueList', { }, { xtype: 'button', - text: me.subject ? Ext.String.format(gettext('Add {0}'), me.subject) : gettext('Add'), + text: me.addLabel ? me.addLabel : gettext('Add'), iconCls: 'fa fa-plus-circle', handler: 'addLine', }, -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel