From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0896E1FF161 for ; Wed, 20 Nov 2024 15:48:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9CE91116F9; Wed, 20 Nov 2024 15:48:18 +0100 (CET) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Wed, 20 Nov 2024 15:47:41 +0100 Message-Id: <20241120144741.866590-1-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.231 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [sdn.rs] Subject: [pve-devel] [PATCH proxmox-perl-rs 1/1] firewall: sdn: ignore EPERM when reading the legacy IPAM file X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On fresh installations, neither the new nor the old IPAM db file exist. This triggers our fallback code path and leads to errors in the syslog on fresh installs where there is no IPAM database. This happens whenever a firewall API call is made. Because of this, we choose to ignore EPERM when reading the legacy files. This is okay, because we move existing databases in the postinstall script of libpve-network-perl, making the situation where the new file does not exist, but the old file exists unlikely. Reported-by: Alexander Zeidler Signed-off-by: Stefan Hanreich --- The change from () to {} is due to rustfmt quirks. Adding the or made rustfmt change () to {()}, leading to another complaint by clippy about an unnecessary unit type in the closure, which I then removed. pve-rs/src/firewall/sdn.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pve-rs/src/firewall/sdn.rs b/pve-rs/src/firewall/sdn.rs index a7d7b80..faf5156 100644 --- a/pve-rs/src/firewall/sdn.rs +++ b/pve-rs/src/firewall/sdn.rs @@ -126,7 +126,9 @@ mod export { Err(e) if e.kind() == io::ErrorKind::NotFound => { match fs::read_to_string(SDN_IPAM_LEGACY) { Ok(data) => add_ipam_ipsets(data)?, - Err(e) if e.kind() == io::ErrorKind::NotFound => (), + Err(e) + if e.kind() == io::ErrorKind::NotFound + || e.kind() == io::ErrorKind::PermissionDenied => {} Err(e) => bail!("Cannot open legacy IPAM database: {e:#}"), } } -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel