From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 876E71FF170 for ; Tue, 19 Nov 2024 16:15:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B70002EB2D; Tue, 19 Nov 2024 16:15:26 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Tue, 19 Nov 2024 16:13:44 +0100 Message-ID: <20241119151443.457187-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.47.0 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH installer v2] first-boot: multi-user: start after product-specific API proxy X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" First of, multi-user.target does not seem to really provide any (strong) ordering guarantee, it seems. Instead, let the "fully-up" ordering from the auto-installer depend on the product-specific API proxy instead. That way, it is ensured that 1) the system really is fully up and 2) that users could even use the API / CLI commands, or write files to pmxcfs (in case of PVE). After= and Wants= ignore non-existent units, so we can just specify all three API proxy units here w/o any conditional. Suggested-by: Shannon Sterz Signed-off-by: Christoph Heiss --- That systemd ignores non-existent for After= and Wants= was definitely a TIL for me, but very convenient in this case :^) v1: https://lore.proxmox.com/pve-devel/20241119143946.370202-1-c.heiss@proxmox.com/ proxmox-first-boot/etc/proxmox-first-boot-multi-user.service | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service b/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service index d3c798d..a99d826 100644 --- a/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service +++ b/proxmox-first-boot/etc/proxmox-first-boot-multi-user.service @@ -1,6 +1,7 @@ [Unit] Description=Proxmox First Boot Setup (Fully Booted) -After=systemd-remount-fs.service +After=systemd-remount-fs.service pveproxy.service pmgproxy.service proxmox-backup-proxy.service +Wants=pveproxy.service pmgproxy.service proxmox-backup-proxy.service ConditionPathExists=/var/lib/proxmox-first-boot/pending-first-boot-setup ConditionPathIsReadWrite=/var/lib -- 2.47.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel