From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 28ED71FF170 for ; Tue, 19 Nov 2024 14:03:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7B6DA2BDAF; Tue, 19 Nov 2024 14:03:12 +0100 (CET) From: Christian Ebner To: pve-devel@lists.proxmox.com Date: Tue, 19 Nov 2024 14:02:53 +0100 Message-Id: <20241119130253.230740-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH proxmox-widget-toolkit] utils: never translate systemd unit states X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Translating unit states might be counter productive in case of debugging, opt for not translating them and drop usage of the translation helper. Signed-off-by: Christian Ebner --- src/Utils.js | 12 ------------ src/node/ServiceView.js | 10 ++-------- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/src/Utils.js b/src/Utils.js index 978b558..1ee4039 100644 --- a/src/Utils.js +++ b/src/Utils.js @@ -306,18 +306,6 @@ utilities: { return Ext.htmlEncode(username); }, - systemdStates: { - 'enabled': gettext('enabled'), - 'disabled': gettext('disabled'), - 'running': gettext('running'), - 'dead': gettext('dead'), - 'not-found': gettext('not installed'), - 'static': gettext('static'), - 'reload': gettext('reload'), - 'start': gettext('starting'), - 'stop': gettext('stopping'), - }, - getStoredAuth: function() { let storedAuth = JSON.parse(window.localStorage.getItem('ProxmoxUser')); return storedAuth || {}; diff --git a/src/node/ServiceView.js b/src/node/ServiceView.js index 94f523c..210dd83 100644 --- a/src/node/ServiceView.js +++ b/src/node/ServiceView.js @@ -201,10 +201,7 @@ Ext.define('Proxmox.node.ServiceView', { width: 100, sortable: true, dataIndex: 'state', - renderer: (value, meta, rec) => { - const state = rec.get('state'); - return Proxmox.Utils.systemdStates[state] ?? state; - }, + renderer: (value, meta, rec) => rec.get('state'), }, { header: gettext('Active'), @@ -219,10 +216,7 @@ Ext.define('Proxmox.node.ServiceView', { sortable: true, hidden: !Ext.Array.contains(['PVEAuthCookie', 'PBSAuthCookie'], Proxmox?.Setup?.auth_cookie_name), dataIndex: 'unit-state', - renderer: (value, meta, rec) => { - const unitState = rec.get('unit-state'); - return Proxmox.Utils.systemdStates[unitState] ?? unitState; - }, + renderer: (value, meta, rec) => rec.get('unit-state'), }, { header: gettext('Description'), -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel