From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CFCEC1FF170 for ; Tue, 19 Nov 2024 13:23:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B77382AD94; Tue, 19 Nov 2024 13:23:34 +0100 (CET) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Tue, 19 Nov 2024 13:22:55 +0100 Message-Id: <20241119122257.132841-9-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241119122257.132841-1-s.hanreich@proxmox.com> References: <20241119122257.132841-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.234 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH pve-manager v6 08/10] firewall: rules: show warning when creating forward rules X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Since forward rules only take effect when the nftables firewall is enabled, show a warning to users that informs them of this. Signed-off-by: Stefan Hanreich --- www/manager6/grid/FirewallRules.js | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/www/manager6/grid/FirewallRules.js b/www/manager6/grid/FirewallRules.js index e2809f02b..f8ee63783 100644 --- a/www/manager6/grid/FirewallRules.js +++ b/www/manager6/grid/FirewallRules.js @@ -174,6 +174,7 @@ Ext.define('PVE.FirewallRulePanel', { firewall_type: undefined, action_selector: undefined, + forward_warning: undefined, onGetValues: function(values) { var me = this; @@ -199,11 +200,17 @@ Ext.define('PVE.FirewallRulePanel', { me.action_selector.setComboItems(allowed_actions.map((action) => [action, action])); }, + setForwardWarning: function(type) { + let me = this; + me.forward_warning.setHidden(type !== 'forward'); + }, + onSetValues: function(values) { let me = this; if (values.type) { me.setValidActions(values.type); + me.setForwardWarning(values.type); } return values; @@ -227,6 +234,12 @@ Ext.define('PVE.FirewallRulePanel', { allowBlank: false, }); + me.forward_warning = Ext.create('Proxmox.form.field.DisplayEdit', { + userCls: 'pmx-hint', + value: gettext('Forward rules only take effect when the nftables firewall is activated in the host options'), + hidden: true, + }); + me.column1 = [ { // hack: we use this field to mark the form 'dirty' when the @@ -246,6 +259,7 @@ Ext.define('PVE.FirewallRulePanel', { listeners: { change: function(f, value) { me.setValidActions(value); + me.setForwardWarning(value); }, }, }, @@ -420,9 +434,17 @@ Ext.define('PVE.FirewallRulePanel', { value: '', fieldLabel: gettext('Comment'), }, + me.forward_warning, ]; me.callParent(); + + if (me.isCreate) { + // on create we never change the values, so we need to trigger this + // manually + me.setValidActions(me.getValues().type); + me.setForwardWarning(me.getValues().type); + } }, }); -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel