From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id D66821FF170 for ; Tue, 19 Nov 2024 12:12:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E27B828A8F; Tue, 19 Nov 2024 12:12:44 +0100 (CET) From: Mira Limbeck To: pve-devel@lists.proxmox.com Date: Tue, 19 Nov 2024 12:12:41 +0100 Message-Id: <20241119111241.97092-1-m.limbeck@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.564 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH v2 installer] warn if maxvz is set <= 4 GiB X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" If it is set and 0, don't warn. Signed-off-by: Mira Limbeck --- v2: - added check != 0 - fixed punctuation in text Proxmox/Install.pm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index c64e1d4..e278917 100644 --- a/Proxmox/Install.pm +++ b/Proxmox/Install.pm @@ -555,6 +555,10 @@ sub create_lvm_volumes { my $maxvz = Proxmox::Install::Config::get_maxvz(); if ($iso_env->{product} eq 'pve' && !defined($maxvz)) { Proxmox::UI::message("Skipping auto-creation of LVM thinpool for guest data due to low space."); + } elsif ($iso_env->{product} eq 'pve' && $maxvz != 0) { + Proxmox::UI::message( + "Skipping auto-creation of LVM thinpool for guest data. Maximum data volume size set too low." + ); } $datadev = undef; } -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel