From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1A4781FF15F for ; Mon, 18 Nov 2024 16:32:02 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EF46713B1F; Mon, 18 Nov 2024 16:30:12 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 18 Nov 2024 16:29:28 +0100 Message-Id: <20241118152928.858590-26-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241118152928.858590-1-d.csapak@proxmox.com> References: <20241118152928.858590-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v7 9/9] ui: import: adapt live import help text to ova X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" For ova import, the help text for live-import is not really fitting, as there is no 'old' vm that needs to be stopped, etc. So show a more appropriate one if we import an ova Signed-off-by: Dominik Csapak --- new in v7 www/manager6/window/GuestImport.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/www/manager6/window/GuestImport.js b/www/manager6/window/GuestImport.js index 7c263241..022e85a3 100644 --- a/www/manager6/window/GuestImport.js +++ b/www/manager6/window/GuestImport.js @@ -315,6 +315,8 @@ Ext.define('PVE.window.GuestImport', { liveImportNote: get => !get('liveImport') ? '' : gettext('Note: If anything goes wrong during the live-import, new data written by the VM may be lost.'), isWindows: get => (get('os') ?? '').startsWith('w'), + liveImportText: get => get('isOva') ? gettext('Starts a VM and imports the disks in the background') + : gettext('Starts a previously stopped VM on Proxmox VE and imports the disks in the background.'), }, }, @@ -582,9 +584,9 @@ Ext.define('PVE.window.GuestImport', { fieldLabel: gettext('Live Import'), reference: 'liveimport', isFormField: false, - boxLabel: gettext('Starts a previously stopped VM on Proxmox VE and imports the disks in the background.'), bind: { value: '{liveImport}', + boxLabel: '{liveImportText}', }, }, { -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel