From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5F7E71FF15F for ; Mon, 18 Nov 2024 13:40:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8D01DFB3C; Mon, 18 Nov 2024 13:40:13 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Mon, 18 Nov 2024 13:38:39 +0100 Message-ID: <20241118123843.1090243-4-c.heiss@proxmox.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241118123843.1090243-1-c.heiss@proxmox.com> References: <20241118123843.1090243-1-c.heiss@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH installer v2 3/5] fix #5579: auto-install-assistant: enable baking in first-boot script X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Adds a new parameter `--on-first-boot` to the `prepare-iso` command, to specify a file to bake into the ISO. To later use it with the auto-installer, the following must be set in the answer file: [first-boot] source = "from-iso" Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * add filesize check; only allow up to 1 MiB scripts proxmox-auto-install-assistant/Cargo.toml | 1 + proxmox-auto-install-assistant/src/main.rs | 30 +++++++++++++++++++++- proxmox-installer-common/src/lib.rs | 6 +++++ 3 files changed, 36 insertions(+), 1 deletion(-) diff --git a/proxmox-auto-install-assistant/Cargo.toml b/proxmox-auto-install-assistant/Cargo.toml index c4486f8..07e6ffb 100644 --- a/proxmox-auto-install-assistant/Cargo.toml +++ b/proxmox-auto-install-assistant/Cargo.toml @@ -13,6 +13,7 @@ homepage = "https://www.proxmox.com" [dependencies] anyhow.workspace = true log.workspace = true +proxmox-installer-common.workspace = true proxmox-auto-installer.workspace = true serde = { workspace = true, features = ["derive"] } serde_json.workspace = true diff --git a/proxmox-auto-install-assistant/src/main.rs b/proxmox-auto-install-assistant/src/main.rs index bdcf067..d7aa134 100644 --- a/proxmox-auto-install-assistant/src/main.rs +++ b/proxmox-auto-install-assistant/src/main.rs @@ -19,6 +19,7 @@ use proxmox_auto_installer::{ FetchAnswerFrom, HttpOptions, }, }; +use proxmox_installer_common::{FIRST_BOOT_EXEC_MAX_SIZE, FIRST_BOOT_EXEC_NAME}; static PROXMOX_ISO_FLAG: &str = "/auto-installer-capable"; @@ -149,6 +150,13 @@ struct CommandPrepareISO { // so shorten "Automated Installer Source" to "AIS" to be safe. #[arg(long, default_value_t = { "proxmox-ais".to_owned() } )] partition_label: String, + + /// Executable file to include, which should be run on the first system boot after the + /// installation. Can be used for further bootstrapping the new system. + /// + /// Must be appropriately enabled in the answer file. + #[arg(long)] + on_first_boot: Option, } /// Show the system information that can be used to identify a host. @@ -201,7 +209,7 @@ fn main() { Commands::SystemInfo(args) => show_system_info(args), }; if let Err(err) = res { - eprintln!("{err}"); + eprintln!("Error: {err:?}"); std::process::exit(1); } } @@ -305,6 +313,17 @@ fn prepare_iso(args: &CommandPrepareISO) -> Result<()> { bail!("You must set '--fetch-from' to 'iso' to place the answer file directly in the ISO."); } + if let Some(first_boot) = &args.on_first_boot { + let metadata = fs::metadata(first_boot)?; + + if metadata.len() > FIRST_BOOT_EXEC_MAX_SIZE.try_into()? { + bail!( + "Maximum file size for first-boot executable file is {} MiB", + FIRST_BOOT_EXEC_MAX_SIZE / 1024 / 1024 + ) + } + } + if let Some(file) = &args.answer_file { println!("Checking provided answer file..."); parse_answer(file)?; @@ -352,6 +371,15 @@ fn prepare_iso(args: &CommandPrepareISO) -> Result<()> { inject_file_to_iso(&tmp_iso, answer_file, "/answer.toml", &uuid)?; } + if let Some(first_boot) = &args.on_first_boot { + inject_file_to_iso( + &tmp_iso, + first_boot, + &format!("/{FIRST_BOOT_EXEC_NAME}"), + &uuid, + )?; + } + println!("Moving prepared ISO to target location..."); fs::rename(&tmp_iso, &iso_target)?; println!("Final ISO is available at {iso_target:?}."); diff --git a/proxmox-installer-common/src/lib.rs b/proxmox-installer-common/src/lib.rs index 10b5940..13acb89 100644 --- a/proxmox-installer-common/src/lib.rs +++ b/proxmox-installer-common/src/lib.rs @@ -11,3 +11,9 @@ pub const RUNTIME_DIR: &str = "/run/proxmox-installer"; /// Default placeholder value for the administrator email address. pub const EMAIL_DEFAULT_PLACEHOLDER: &str = "mail@example.invalid"; + +/// Name of the executable for the first-boot hook. +pub const FIRST_BOOT_EXEC_NAME: &str = "proxmox-first-boot"; + +/// Maximum file size for the first-boot hook executable. +pub const FIRST_BOOT_EXEC_MAX_SIZE: usize = 1024 * 1024; // 1 MiB -- 2.47.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel