From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 716431FF15F for ; Mon, 18 Nov 2024 11:45:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 69BB1CEC8; Mon, 18 Nov 2024 11:45:33 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Mon, 18 Nov 2024 11:45:28 +0100 Message-Id: <20241118104530.91798-2-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241118104530.91798-1-a.lauterer@proxmox.com> References: <20241118104530.91798-1-a.lauterer@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.035 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit v3 1/3] node tasks: add action column with button to view task X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This is primarily aimed to make it more discoverable that one can open tasks directly, instead of selecting and clicking the view button at the top. The chevron-right icon was chosen, to be more in alignmend with other places where we use it. For now, mainly PBS. Signed-off-by: Aaron Lauterer --- I placed the actioncolumn at the end. See the cover letter for the reasoning. Placing it anywhere else in the grid should just be a yank/paste. changes since v2: * new patch src/node/Tasks.js | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/src/node/Tasks.js b/src/node/Tasks.js index 62c9c18..31052b7 100644 --- a/src/node/Tasks.js +++ b/src/node/Tasks.js @@ -441,6 +441,25 @@ Ext.define('Proxmox.node.Tasks', { return Proxmox.Utils.format_task_status(value); }, }, + { + xtype: 'actioncolumn', + width: 30, + align: 'center', + tooltip: gettext('Actions'), + items: [ + { + iconCls: 'fa fa-chevron-right', + tooltip: gettext('View Task'), + handler: function(_grid, _rowIndex, _colIndex, _item, _e, rec) { + Ext.create('Proxmox.window.TaskViewer', { + autoShow: true, + upid: rec.data.upid, + endtime: rec.data.endtime, + }); + }, + }, + ], + }, ], initComponent: function() { -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel