From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1D3AB1FF15F for ; Mon, 18 Nov 2024 11:46:05 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 78611D064; Mon, 18 Nov 2024 11:46:04 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Mon, 18 Nov 2024 11:45:27 +0100 Message-Id: <20241118104530.91798-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.035 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit, manager v3 0/3] ui: tasks: add button to X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Especially in the task-log at the bottom in PVE, users might not realize that they can open the task log with a double-click. By adding an action column with a button, this should be easier to discover. While we are at it, let's have it in the task view panel as well. Here it can help save clicks for non-double-click users as they don't have to select and then go to the "view" button. The tooltip is "View Task". This should leave no ambiguity in that it is a read-only operation. One patch aligns the button at the top of the task panel. Using the "chevron-right" icon was initially done to align with how we do that in the pbs UI. Especially in the task panel, I stuck with it, as a test with the "window-open" icon, that is used in the button at the top, resulted in quite the visual noise IMHO. Regarding the placement in the grids after a discussion with Dominik: putting the action column as first column reduces mouse travel, but is a rather uncommon placement. It would either be seen just as the icon, or an option to expand/collapse that row. It is more common, and thus the user expectaion, to have these buttons rather at the end of the row. This is why I send the patches with the action columns as the last in the grid. It is not the only option, one can of course double click anywhere on the row too. changes sinve v2: * add the action column to the tasks panel in the widget toolkit * align button in the widget toolkits tasks panel to match the tooltip widget-toolkit: Aaron Lauterer (2): node tasks: add action column with button to view task node tasks: align view task button label to other uses src/node/Tasks.js | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) manager: Aaron Lauterer (1): ui: tasks: add actioncolumn to open task www/manager6/dc/Tasks.js | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel