From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A8C1F1FF16F for <inbox@lore.proxmox.com>; Fri, 15 Nov 2024 17:58:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C870B1A132; Fri, 15 Nov 2024 17:58:26 +0100 (CET) From: Aaron Lauterer <a.lauterer@proxmox.com> To: pve-devel@lists.proxmox.com Date: Fri, 15 Nov 2024 17:57:49 +0100 Message-Id: <20241115165753.2664489-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.037 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [network.pm] Subject: [pve-devel] [PATCH widget-toolkit v7 0/4] fix #3893: make bridge vids configurable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> After some back and forth on v5 regarding the UI label and extra textinfo, another series. I dropped the T-B and R-B tags for this series, as the last non-trivial patch that had them changed the appearance of the UI field considerably. this version reworks a few parts since v6: * drop extra explanation field for bridge VIDS and move the info into the tooltip * Revert UI Label * increase label width to avoid linebreak v5: * drop PVE::Tools::list_is_empty completely and run the empty check directly in the two call sites * Change UI label and description text * Put UI description text into a gettext v4: incorporated @fionas suggestions, besides some style nits: * rename check_list_empty to list_is_empty and adapt the return values * renamed $check_vid to $valid_vid with return values for each case * switch list separators to spaces in the API call, instead of when writing the file * rework small logical error in the check if the end VLAN ID is larger than the start and $noerr is set. v3: incorporated @shannons recommendations, in detail: * improve regex with non-capturing group * reworked check if valid VLAN config in UI field check * small code style and spelling things * reworded UI explanation text for bridge vids v2: * renamed format in JSONSchema to a more generic `pve-vlan-id-or-range` * explicitly use spaces when writing interfaces file. This is one possible approach to deal with the fact, that the generic `-list` format will accept quite a few delimiters and we need spaces. * code style improvements such as naming the regex results. * add parameter verification to the web ui widget-toolkit: Aaron Lauterer (2): fix #3892: network: add bridge vids field for bridge_vids network: make bridge vids label wider to avoid line break src/node/NetworkEdit.js | 66 +++++++++++++++++++++++++++++++++++++++++ src/node/NetworkView.js | 5 ++++ 2 files changed, 71 insertions(+) manager: Aaron Lauterer (2): fix #3893: api: network: add bridge_vids parameter fix #3893: ui: network: enable bridge_vids field PVE/API2/Network.pm | 23 ++++++++++++++++++++++- www/manager6/node/Config.js | 1 + 2 files changed, 23 insertions(+), 1 deletion(-) -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel