From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 789D31FF16F for ; Fri, 15 Nov 2024 13:43:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EA33813433; Fri, 15 Nov 2024 13:43:35 +0100 (CET) From: Christian Ebner To: pve-devel@lists.proxmox.com Date: Fri, 15 Nov 2024 13:43:18 +0100 Message-Id: <20241115124318.179424-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [install.pm] Subject: [pve-devel] [PATCH installer] install: ask for patience when making system bootable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Making the system bootable can take some time if many disks are used for installation, which could be misinterpreted as a hanging installer. Add a please be patient output when more than 3 disks are used. Output changes from `make system bootable` to `make system bootable (please be patient)` Signed-off-by: Christian Ebner --- Proxmox/Install.pm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index 5c64c3d..5c59485 100644 --- a/Proxmox/Install.pm +++ b/Proxmox/Install.pm @@ -723,6 +723,7 @@ sub extract_data { } my $bootloader_err; + my $diskcount = 0; eval { my $maxper = 0.25; @@ -761,6 +762,7 @@ sub extract_data { } elsif ($use_btrfs) { my ($devlist, $btrfs_mode) = get_btrfs_raid_setup(); + $diskcount = scalar(@$devlist); foreach my $hd (@$devlist) { wipe_disk(@$hd[1]); @@ -795,6 +797,7 @@ sub extract_data { } elsif ($use_zfs) { my ($devlist, $vdev) = get_zfs_raid_setup(); + $diskcount = scalar(@$devlist); foreach my $hd (@$devlist) { wipe_disk(@$hd[1]); @@ -842,6 +845,7 @@ sub extract_data { } else { my $target_hd = Proxmox::Install::Config::get_target_hd(); die "target '$target_hd' is not a valid block device\n" if ! -b $target_hd; + $diskcount = 1; wipe_disk($target_hd); @@ -1241,7 +1245,9 @@ _EOD debconfig_set($targetdir, "pve-manager pve-manager/country string $ucc\n"); } - update_progress(0.8, 0.95, 1, "make system bootable"); + my $ask_for_patience = ""; + $ask_for_patience = " (please be patient)" if $diskcount > 3; + update_progress(0.8, 0.95, 1, "make system bootable$ask_for_patience"); my $target_cmdline=''; if ($target_cmdline = Proxmox::Install::Config::get_target_cmdline()) { my $target_cmdline_snippet = ''; -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel