From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9324A1FF16F for ; Fri, 15 Nov 2024 13:33:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F1F3013239; Fri, 15 Nov 2024 13:33:58 +0100 (CET) From: Hannes Laimer To: pve-devel@lists.proxmox.com Date: Fri, 15 Nov 2024 13:33:21 +0100 Message-Id: <20241115123321.49338-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pve-devel] [PATCH] firewall: resources: accept invalid ct state by default X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" We only add a `block-conntrack-invalid` jump to the in chain, if the `nf_conntrack_allow_invalid` option is not set in the config. But we already drop connections with an invalid ct state by default. So we have to either allow connections with an invalid ct state by default, or explicitly allow them when checking for the option and keeping them blocked by default. I chose to change the 'default' as it has the same result but is simpler a change. Signed-off-by: Hannes Laimer --- relevant code[1] ``` if self.config.host().block_invalid_conntrack() { log::debug!("set block_invalid_conntrack"); commands.push(Add::rule(AddRule::from_statement( chain_in, Statement::jump("block-conntrack-invalid"), ))); } ``` I am not sure whether adding a jump to `block-conntrack-invalid` would also make sense for the out chain. [1] https://git.proxmox.com/?p=proxmox-firewall.git;a=blob;f=proxmox-firewall/src/firewall.rs;h=941aa2008b4e3a22d9b37a0f8bc39c3643eb97c8;hb=bea3e651b47f2a9113b93e45db2904ddfd2fe174#l394 proxmox-firewall/resources/proxmox-firewall.nft | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/proxmox-firewall/resources/proxmox-firewall.nft b/proxmox-firewall/resources/proxmox-firewall.nft index f42255c..be9a930 100644 --- a/proxmox-firewall/resources/proxmox-firewall.nft +++ b/proxmox-firewall/resources/proxmox-firewall.nft @@ -316,7 +316,7 @@ table bridge proxmox-firewall-guests { } chain pre-vm-out { - meta protocol != arp ct state vmap { established : accept, related : accept, invalid : drop } + meta protocol != arp ct state vmap { established : accept, related : accept, invalid : accept } } chain vm-out { @@ -326,7 +326,7 @@ table bridge proxmox-firewall-guests { } chain pre-vm-in { - meta protocol != arp ct state vmap { established : accept, related : accept, invalid : drop } + meta protocol != arp ct state vmap { established : accept, related : accept, invalid : accept } meta protocol arp accept } -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel