From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C920D1FF16B for ; Thu, 14 Nov 2024 15:16:15 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C989C31A3F; Thu, 14 Nov 2024 15:16:12 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Thu, 14 Nov 2024 15:15:26 +0100 Message-ID: <20241114141533.694491-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.47.0 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [main.rs, mod.rs, parse-answer.rs, proxmox.com, setup.rs] Subject: [pve-devel] [PATCH installer v3 0/2] assistant: clean up glob patterns & regexes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The proxmox-auto-install-assistant uses regexes for udev property matching, which can be simplified by some simple prefix matching and splitting on '='. The latter also significantly reduces binary size (-46%) due to the removing the regex dependency, for details see patch #2. Overall no functional changes in this series. history ======= v2: https://lore.proxmox.com/pve-devel/20240513094936.412650-1-c.heiss@proxmox.com/ v1: https://lists.proxmox.com/pipermail/pve-devel/2024-May/063802.html Changes v2 -> v3: * rebased on latest master, dropping applied & obsolete patches Changes v1 -> v2: * rebased on latest master Christoph Heiss (2): tree-wide: run rustfmt, fix clippy warnings assistant: avoid regex for simple prefix matching proxmox-auto-install-assistant/src/main.rs | 61 +++++++++----------- proxmox-auto-installer/tests/parse-answer.rs | 2 +- proxmox-installer-common/src/setup.rs | 5 +- proxmox-tui-installer/src/views/mod.rs | 2 +- 4 files changed, 32 insertions(+), 38 deletions(-) -- 2.44.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel