From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 927551FF16B for ; Thu, 14 Nov 2024 10:33:52 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 946772C5A8; Thu, 14 Nov 2024 10:32:41 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 14 Nov 2024 10:32:25 +0100 Message-Id: <20241114093226.814530-25-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241114093226.814530-1-d.csapak@proxmox.com> References: <20241114093226.814530-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v5 8/9] ui: guest import: change icon/text for non-esxi import storage X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" since 'virtual guests' only make sense for a hypervisor, not e.g. a directory for OVAs also change the icon from 'desktop' to 'cloud-download' in the non-esxi case Signed-off-by: Dominik Csapak --- www/manager6/storage/Browser.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/www/manager6/storage/Browser.js b/www/manager6/storage/Browser.js index 822257e7..763abc70 100644 --- a/www/manager6/storage/Browser.js +++ b/www/manager6/storage/Browser.js @@ -141,8 +141,10 @@ Ext.define('PVE.storage.Browser', { }; me.items.push({ xtype: 'pveStorageContentView', - title: gettext('Virtual Guests'), - iconCls: 'fa fa-desktop', + // each gettext needs to be in a separate line + title: isEsxi ? gettext('Virtual Guests') + : gettext('Import'), + iconCls: isEsxi ? 'fa fa-desktop' : 'fa fa-cloud-download', itemId: 'contentImport', content: 'import', useCustomRemoveButton: isEsxi, // hide default remove button for esxi -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel