From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 915A01FF16B for ; Thu, 14 Nov 2024 09:05:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E09AF2A34F; Thu, 14 Nov 2024 09:05:08 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 14 Nov 2024 09:04:35 +0100 Message-Id: <20241114080435.241891-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] ui: tree: show tooltips for all entries that have sensible information X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" instead of filtering pools and groups out manually, simply accumulate the info we want to to have (status/hastate/etc.) and if any of those exist, show the tooltip. This results in the nodes also having a tooltip, including their hastate (such as online/maintenance), and automatically would show such things in the future if we add those fields to other entries. Signed-off-by: Dominik Csapak --- www/manager6/tree/ResourceTree.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js index 312f958f..a7acdf93 100644 --- a/www/manager6/tree/ResourceTree.js +++ b/www/manager6/tree/ResourceTree.js @@ -148,11 +148,10 @@ Ext.define('PVE.tree.ResourceTree', { }, getToolTip: function(info) { - if (info.type === 'pool' || info.groupbyid !== undefined) { - return undefined; + let qtips = []; + if (info.qmpstatus || info.status) { + qtips.push(gettext('Status') + ': ' + (info.qmpstatus || info.status)); } - - let qtips = [gettext('Status') + ': ' + (info.qmpstatus || info.status)]; if (info.lock) { qtips.push(Ext.String.format(gettext('Config locked ({0})'), info.lock)); } @@ -166,6 +165,10 @@ Ext.define('PVE.tree.ResourceTree', { } } + if (qtips.length === 0) { + return undefined; + } + let tip = qtips.join(', '); info.tip = tip; return tip; -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel