From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 14C971FF168 for ; Tue, 12 Nov 2024 13:50:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6759D2919E; Tue, 12 Nov 2024 13:50:09 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Tue, 12 Nov 2024 13:49:08 +0100 Message-ID: <20241112125000.583271-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.47.0 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH installer] tree-wide: add serde `derive` where actually needed X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Fixes building each crate on their own. In a full build (e.g. `make deb`), everything pulls in serde with the `derive` feature anyway and thus does not exihibit any build failures. Signed-off-by: Christoph Heiss --- Only noticed this by pure chance while using `cargo test -p proxmox-tui-installer`. Interesting though that a full build does not break, which is why I didn't notice it until now .. proxmox-installer-common/Cargo.toml | 2 +- proxmox-post-hook/Cargo.toml | 2 +- proxmox-tui-installer/Cargo.toml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/proxmox-installer-common/Cargo.toml b/proxmox-installer-common/Cargo.toml index ef7a614..b97ccaf 100644 --- a/proxmox-installer-common/Cargo.toml +++ b/proxmox-installer-common/Cargo.toml @@ -10,7 +10,7 @@ homepage = "https://www.proxmox.com" [dependencies] anyhow.workspace = true regex.workspace = true -serde.workspace = true +serde = { workspace = true, features = [ "derive" ] } serde_json.workspace = true serde_plain.workspace = true diff --git a/proxmox-post-hook/Cargo.toml b/proxmox-post-hook/Cargo.toml index 3acea6c..a2ca206 100644 --- a/proxmox-post-hook/Cargo.toml +++ b/proxmox-post-hook/Cargo.toml @@ -14,5 +14,5 @@ homepage = "https://www.proxmox.com" anyhow.workspace = true proxmox-auto-installer.workspace = true proxmox-installer-common = { workspace = true, features = ["http"] } -serde.workspace = true +serde = { workspace = true, features = ["derive"] } serde_json.workspace = true diff --git a/proxmox-tui-installer/Cargo.toml b/proxmox-tui-installer/Cargo.toml index c7a0e30..4b11576 100644 --- a/proxmox-tui-installer/Cargo.toml +++ b/proxmox-tui-installer/Cargo.toml @@ -9,7 +9,7 @@ homepage = "https://www.proxmox.com" [dependencies] proxmox-installer-common.workspace = true -serde.workspace = true +serde = { workspace = true, features = ["derive"] } serde_json.workspace = true regex.workspace = true -- 2.47.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel