From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 57BAE1FF173 for ; Mon, 11 Nov 2024 15:46:02 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 20AD8E548; Mon, 11 Nov 2024 15:46:02 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Mon, 11 Nov 2024 15:45:28 +0100 Message-Id: <20241111144529.322168-2-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241111144529.322168-1-a.lauterer@proxmox.com> References: <20241111144529.322168-1-a.lauterer@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 1/2] ui: tasks: add actioncolumn to open task X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Many (new) users don't realize that the task view can be used to open the task details. By adding a small action column we can have a button to open the task as well, next to double clicking it. Signed-off-by: Aaron Lauterer --- Since the record is fetched quite differently than in the regular handler, and we don't necessarily have a selection on the right row at this point, I opted to create the window right in the dedicated handler. The other sensible approach would be to factor out the window opening from `run_task_viewer` into a new function. But since that function would just open the window I decided against it. Not sure if we want the above explanation in the commit msg. If so, feel free to put it there when applying the patch. Regarding the icon: I went with the chevron-right as this is what we use in the UI of the backup server. Alternatively the `fa-eye` might also be fitting. www/manager6/dc/Tasks.js | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/www/manager6/dc/Tasks.js b/www/manager6/dc/Tasks.js index 2001bf76..43d0dace 100644 --- a/www/manager6/dc/Tasks.js +++ b/www/manager6/dc/Tasks.js @@ -127,6 +127,26 @@ Ext.define('PVE.dc.Tasks', { return Proxmox.Utils.format_task_status(value); }, }, + { + xtype: 'actioncolumn', + width: 30, + align: 'center', + tooltip: gettext('Actions'), + items: [ + { + iconCls: 'fa fa-chevron-right', + tooltip: gettext('Show Task'), + handler: function(grid, rowIndex, colIndex) { + let rec = grid.getStore().getAt(rowIndex); + Ext.create('Proxmox.window.TaskViewer', { + autoShow: true, + upid: rec.data.upid, + endtime: rec.data.endtime, + }); + }, + }, + ], + }, ], listeners: { itemdblclick: run_task_viewer, -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel