From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7133A1FF173 for ; Mon, 11 Nov 2024 14:57:58 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2EFAECDFF; Mon, 11 Nov 2024 14:57:58 +0100 (CET) From: Markus Frank To: pve-devel@lists.proxmox.com Date: Mon, 11 Nov 2024 14:57:08 +0100 Message-Id: <20241111135713.212601-2-m.frank@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241111135713.212601-1-m.frank@proxmox.com> References: <20241111135713.212601-1-m.frank@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH guest-common v12 1/6] AbstractConfig: add abstract method to check for resources preventing a snapshot X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Signed-off-by: Markus Frank Suggested-by: Fiona Ebner --- This patch is new in v12. src/PVE/AbstractConfig.pm | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/PVE/AbstractConfig.pm b/src/PVE/AbstractConfig.pm index 5d5f9b4..3d4fcbb 100644 --- a/src/PVE/AbstractConfig.pm +++ b/src/PVE/AbstractConfig.pm @@ -579,6 +579,13 @@ sub __snapshot_check_running { die "implement me - abstract method\n"; } +# Abstract method: Check if there is a resource preventing a snapshot. +sub __snapshot_assert_no_blockers { + my ($class, $vmconf, $save_vmstate) = @_; + + return; +} + # Check whether we need to freeze the VM/CT sub __snapshot_check_freeze_needed { my ($sself, $vmid, $config, $save_vmstate) = @_; @@ -726,6 +733,8 @@ sub __snapshot_prepare { $class->check_lock($conf); + $class->__snapshot_assert_no_blockers($conf, $save_vmstate); + $conf->{lock} = 'snapshot'; my $snapshots = $conf->{snapshots}; -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel