From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1A5B71FF173 for <inbox@lore.proxmox.com>; Mon, 11 Nov 2024 14:55:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0CDB5C955; Mon, 11 Nov 2024 14:55:15 +0100 (CET) From: Fiona Ebner <f.ebner@proxmox.com> To: pve-devel@lists.proxmox.com Date: Mon, 11 Nov 2024 14:54:34 +0100 Message-Id: <20241111135436.82773-8-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241111135436.82773-1-f.ebner@proxmox.com> References: <20241111135436.82773-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v4 qemu-server 7/9] fix #5440: vzdump: better cleanup fleecing images after hard errors X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> QnkgcmVjb3JkaW5nIHRoZSBhbGxvY2F0ZWQgZmxlZWNpbmcgaW1hZ2VzIGluIHRoZSBWTSBjb25m aWcsIHRoZXkKYXJlIG5vdCBpbW1lZGlhdGVseSBvcnBoYW5lZCwgc2hvdWxkIGEgaGFyZCBlcnJv ciBvY2N1ciBkdXJpbmcKYmFja3VwIHRoYXQgcHJldmVudHMgY2xlYW51cC4KClRoZXkgYXJlIGF0 dGVtcHRlZCB0byBiZSBjbGVhbmVkIHVwIGR1cmluZyB0aGUgbmV4dCBiYWNrdXAgcnVuLgoKU3Vn Z2VzdGVkLWJ5OiBGYWJpYW4gR3LDvG5iaWNobGVyIDxmLmdydWVuYmljaGxlckBwcm94bW94LmNv bT4KU2lnbmVkLW9mZi1ieTogRmlvbmEgRWJuZXIgPGYuZWJuZXJAcHJveG1veC5jb20+Ci0tLQoK Q2hhbmdlcyBpbiB2NDoKKiBkZXRhY2ggbGVmdC1vdmVyIGZsZWVjaW5nIGltYWdlcyBmcm9tIGEg cnVubmluZyBWTSBiZWZvcmUgYXR0ZW1wdGluZwogIGNsZWFudXAKKiBtb3JlIGxvZ2dpbmcKCiBQ VkUvUWVtdUNvbmZpZy5wbSAgICAgICAgfCA2OCArKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrCiBQVkUvVlpEdW1wL1FlbXVTZXJ2ZXIucG0gfCAzNiArKysrKysrKysrKysr KysrLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgOTcgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9QVkUvUWVtdUNvbmZpZy5wbSBiL1BWRS9RZW11Q29uZmlnLnBtCmlu ZGV4IDhlOGE3ODI4Li4zMDg0ZjgzMSAxMDA2NDQKLS0tIGEvUFZFL1FlbXVDb25maWcucG0KKysr IGIvUFZFL1FlbXVDb25maWcucG0KQEAgLTEzLDYgKzEzLDcgQEAgdXNlIFBWRTo6UWVtdVNlcnZl cjo6TW9uaXRvciBxdyhtb25fY21kKTsKIHVzZSBQVkU6OlFlbXVTZXJ2ZXI7CiB1c2UgUFZFOjpR ZW11U2VydmVyOjpNYWNoaW5lOwogdXNlIFBWRTo6UWVtdVNlcnZlcjo6TWVtb3J5IHF3KGdldF9j dXJyZW50X21lbW9yeSk7Cit1c2UgUFZFOjpSRVNURW52aXJvbm1lbnQgcXcobG9nX3dhcm4pOwog dXNlIFBWRTo6U3RvcmFnZTsKIHVzZSBQVkU6OlRvb2xzOwogdXNlIFBWRTo6Rm9ybWF0IHF3KHJl bmRlcl9ieXRlcyByZW5kZXJfZHVyYXRpb24pOwpAQCAtNTczLDQgKzU3NCw3MSBAQCBzdWIgaGFz X2Nsb3VkaW5pdCB7CiAgICAgcmV0dXJuICRmb3VuZDsKIH0KIAorIyBDYWxsZXIgaXMgZXhwZWN0 ZWQgdG8gZGVhbCB3aXRoIHZvbHVtZXMgZnJvbSBhbiBhbHJlYWR5IGV4aXN0aW5nICdmbGVlY2lu Zy1pbWFnZXMnIGVudHJ5IGluIHRoZQorIyBjb25maWd1cmF0aW9uIGZpcnN0Lgorc3ViIHJlY29y ZF9mbGVlY2luZ19pbWFnZXMgeworICAgIG15ICgkdm1pZCwgJHZvbGlkcykgPSBAXzsKKworICAg IHJldHVybiBpZiBzY2FsYXIoJHZvbGlkcy0+QCopID09IDA7CisKKyAgICBQVkU6OlFlbXVDb25m aWctPmxvY2tfY29uZmlnKCR2bWlkLCBzdWIgeworCW15ICRjb25mID0gUFZFOjpRZW11Q29uZmln LT5sb2FkX2NvbmZpZygkdm1pZCk7CisJJGNvbmYtPnsnZmxlZWNpbmctaW1hZ2VzJ30gPSBqb2lu KCcsJywgJHZvbGlkcy0+QCopOworCVBWRTo6UWVtdUNvbmZpZy0+d3JpdGVfY29uZmlnKCR2bWlk LCAkY29uZik7CisgICAgfSk7Cit9CisKK3N1YiBjbGVhbnVwX2ZsZWVjaW5nX2ltYWdlcyB7Cisg ICAgbXkgKCR2bWlkLCAkc3RvcmVjZmcsICRsb2dfZnVuYykgPSBAXzsKKworICAgIGlmICghJGxv Z19mdW5jKSB7CisJJGxvZ19mdW5jID0gc3ViIHsKKwkgICAgbXkgKCRsZXZlbCwgJGxpbmUpID0g QF87CisJICAgIGNob21wKCRsaW5lKTsKKwkgICAgaWYgKCRsZXZlbCBlcSAnaW5mbycpIHsKKwkJ cHJpbnQgIiRsaW5lXG4iOworCSAgICB9IGVsc2UgeworCQlsb2dfd2FybigkbGluZSk7CisJICAg IH0KKwl9OworICAgIH0KKworICAgIG15ICR2b2xpZHMgPSBbXTsKKyAgICBteSAkZmFpbGVkID0g W107CisKKyAgICAjIGRldGFjaCBhbnkgbGVmdC1vdmVycyBmcm9tIGEgcnVubmluZyBWTQorICAg IGlmIChQVkU6OlFlbXVTZXJ2ZXI6OkhlbHBlcnM6OnZtX3J1bm5pbmdfbG9jYWxseSgkdm1pZCkp IHsKKwlteSAkYmxvY2tfaW5mbyA9IG1vbl9jbWQoJHZtaWQsICJxdWVyeS1ibG9jayIpOworCWZv ciBteSAkaW5mbyAoJGJsb2NrX2luZm8tPkAqKSB7CisJICAgIG15ICRkZXZpY2VfaWQgPSAkaW5m by0+e2RldmljZX07CisJICAgIG5leHQgaWYgJGRldmljZV9pZCAhfiBtLy1mbGVlY2luZyQvOwor CisJICAgICRsb2dfZnVuYy0+KCdpbmZvJywgImRldGFjaGluZyAob2xkKSBmbGVlY2luZyBpbWFn ZSBmb3IgJyRkZXZpY2VfaWQnIik7CisJICAgICRkZXZpY2VfaWQgPX4gcy9eZHJpdmUtLy87ICMg cmUtYWRkZWQgYnkgcWVtdV9kcml2ZWRlbCgpCisJICAgIGV2YWwgeyBQVkU6OlFlbXVTZXJ2ZXI6 OnFlbXVfZHJpdmVkZWwoJHZtaWQsICRkZXZpY2VfaWQpIH07CisJICAgICRsb2dfZnVuYy0+KCd3 YXJuJywgImVycm9yIGRldGFjaGluZyAob2xkKSBmbGVlY2luZyBpbWFnZSAnJGRldmljZV9pZCcg LSAkQCIpIGlmICRAOworCX0KKyAgICB9CisKKyAgICBQVkU6OlFlbXVDb25maWctPmxvY2tfY29u ZmlnKCR2bWlkLCBzdWIgeworCW15ICRjb25mID0gUFZFOjpRZW11Q29uZmlnLT5sb2FkX2NvbmZp Zygkdm1pZCk7CisJaWYgKCRjb25mLT57J2ZsZWVjaW5nLWltYWdlcyd9KSB7CisJICAgICR2b2xp ZHMgPSBbUFZFOjpUb29sczo6c3BsaXRfbGlzdCgkY29uZi0+eydmbGVlY2luZy1pbWFnZXMnfSld OworCSAgICBkZWxldGUgJGNvbmYtPnsnZmxlZWNpbmctaW1hZ2VzJ307CisJICAgIFBWRTo6UWVt dUNvbmZpZy0+d3JpdGVfY29uZmlnKCR2bWlkLCAkY29uZik7CisJfQorICAgIH0pOworCisgICAg Zm9yIG15ICR2b2xpZCAoJHZvbGlkcy0+QCopIHsKKwkkbG9nX2Z1bmMtPignaW5mbycsICJyZW1v dmluZyAob2xkKSBmbGVlY2luZyBpbWFnZSAnJHZvbGlkJyIpOworCWV2YWwgeyBQVkU6OlN0b3Jh Z2U6OnZkaXNrX2ZyZWUoJHN0b3JlY2ZnLCAkdm9saWQpOyB9OworCWlmIChteSAkZXJyID0gJEAp IHsKKwkgICAgJGxvZ19mdW5jLT4oJ3dhcm4nLCAiZXJyb3IgcmVtb3ZpbmcgZmxlZWNpbmcgaW1h Z2UgJyR2b2xpZCcgLSAkZXJyIik7CisJICAgIHB1c2ggJGZhaWxlZC0+QCosICR2b2xpZDsKKwl9 CisgICAgfQorCisgICAgcmVjb3JkX2ZsZWVjaW5nX2ltYWdlcygkdm1pZCwgJGZhaWxlZCk7Cit9 CisKIDE7CmRpZmYgLS1naXQgYS9QVkUvVlpEdW1wL1FlbXVTZXJ2ZXIucG0gYi9QVkUvVlpEdW1w L1FlbXVTZXJ2ZXIucG0KaW5kZXggMTdmNjM1NjguLjI0MGUxZTk1IDEwMDY0NAotLS0gYS9QVkUv VlpEdW1wL1FlbXVTZXJ2ZXIucG0KKysrIGIvUFZFL1ZaRHVtcC9RZW11U2VydmVyLnBtCkBAIC01 MzAsMTUgKzUzMCwyNSBAQCBzdWIgZ2V0X2FuZF9jaGVja19wYnNfZW5jcnlwdGlvbl9jb25maWcg ewogICAgIGRpZSAiaW50ZXJuYWwgZXJyb3IgLSB1bmhhbmRsZWQgY2FzZSBmb3IgZ2V0dGluZyAm IGNoZWNraW5nIFBCUyBlbmNyeXB0aW9uICgka2V5ZmlsZSwgJG1hc3Rlcl9rZXlmaWxlKSEiOwog fQogCisjIEhlbHBlciBpcyBpbnRlbmRlZCB0byBiZSBjYWxsZWQgZnJvbSBhbGxvY2F0ZV9mbGVl Y2luZ19pbWFnZXMoKSBvbmx5LiBPdGhlcndpc2UsIGZsZWVjaW5nIHZvbGlkcworIyBoYXZlIGFs cmVhZHkgYmVlbiByZWNvcmRlZCBpbiB0aGUgY29uZmlndXJhdGlvbiBhbmQgUFZFOjpRZW11Q29u ZmlnOjpjbGVhbnVwX2ZsZWVjaW5nX2ltYWdlcygpCisjIHNob3VsZCBiZSB1c2VkIGluc3RlYWQu CiBteSBzdWIgY2xlYW51cF9mbGVlY2luZ19pbWFnZXMgewotICAgIG15ICgkc2VsZiwgJGRpc2tz KSA9IEBfOworICAgIG15ICgkc2VsZiwgJHZtaWQsICRkaXNrcykgPSBAXzsKKworICAgIG15ICRm YWlsZWQgPSBbXTsKIAogICAgIGZvciBteSAkZGkgKCRkaXNrcy0+QCopIHsKIAlpZiAobXkgJHZv bGlkID0gJGRpLT57J2ZsZWVjZS12b2xpZCd9KSB7CiAJICAgIGV2YWwgeyBQVkU6OlN0b3JhZ2U6 OnZkaXNrX2ZyZWUoJHNlbGYtPntzdG9yZWNmZ30sICR2b2xpZCk7IH07Ci0JICAgICRzZWxmLT5s b2coJ3dhcm4nLCAiZXJyb3IgcmVtb3ZpbmcgZmxlZWNpbmcgaW1hZ2UgJyR2b2xpZCcgLSAkQCIp IGlmICRAOworCSAgICBpZiAobXkgJGVyciA9ICRAKSB7CisJCSRzZWxmLT5sb2coJ3dhcm4nLCAi ZXJyb3IgcmVtb3ZpbmcgZmxlZWNpbmcgaW1hZ2UgJyR2b2xpZCcgLSAkZXJyIik7CisJCXB1c2gg JGZhaWxlZC0+QCosICR2b2xpZDsKKwkgICAgfQogCX0KICAgICB9CisKKyAgICBQVkU6OlFlbXVD b25maWc6OnJlY29yZF9mbGVlY2luZ19pbWFnZXMoJHZtaWQsICRmYWlsZWQpOwogfQogCiBteSBz dWIgYWxsb2NhdGVfZmxlZWNpbmdfaW1hZ2VzIHsKQEAgLTU0Niw4ICs1NTYsNyBAQCBteSBzdWIg YWxsb2NhdGVfZmxlZWNpbmdfaW1hZ2VzIHsKIAogICAgIGRpZSAiaW50ZXJuYWwgZXJyb3IgLSBu byBmbGVlY2luZyBzdG9yYWdlIHNwZWNpZmllZFxuIiBpZiAhJGZsZWVjaW5nX3N0b3JlaWQ7CiAK LSAgICAjIFRPRE8gd2hhdCBhYm91dCBwb3RlbnRpYWwgbGVmdC1vdmVyIGltYWdlcyBmcm9tIGEg ZmFpbGVkIGF0dGVtcHQ/IEp1c3QKLSAgICAjIGF1dG8tcmVtb3ZlPyBXaGlsZSB1bmxpa2VseSwg Y291bGQgY29uZmxpY3Qgd2l0aCBtYW51YWxseSBjcmVhdGVkIGltYWdlIGZyb20gdXNlci4uLgor ICAgIG15ICRmbGVlY2Vfdm9saWRzID0gW107CiAKICAgICBldmFsIHsKIAlteSAkbiA9IDA7ICMg Y291bnRlciBmb3IgZmxlZWNpbmcgaW1hZ2UgbmFtZXMKQEAgLTU2NCw2ICs1NzMsOCBAQCBteSBz dWIgYWxsb2NhdGVfZmxlZWNpbmdfaW1hZ2VzIHsKIAkJJGRpLT57J2ZsZWVjZS12b2xpZCd9ID0g UFZFOjpTdG9yYWdlOjp2ZGlza19hbGxvYygKIAkJICAgICRzZWxmLT57c3RvcmVjZmd9LCAkZmxl ZWNpbmdfc3RvcmVpZCwgJHZtaWQsICRmb3JtYXQsICRuYW1lLCAkc2l6ZSk7CiAKKwkJcHVzaCAk ZmxlZWNlX3ZvbGlkcy0+QCosICRkaS0+eydmbGVlY2Utdm9saWQnfTsKKwogCQkkbisrOwogCSAg ICB9IGVsc2UgewogCQlkaWUgImltcGxlbWVudCBtZSAodHlwZSAnJGRpLT57dHlwZX0nKSI7CkBA IC01NzEsOSArNTgyLDExIEBAIG15IHN1YiBhbGxvY2F0ZV9mbGVlY2luZ19pbWFnZXMgewogCX0K ICAgICB9OwogICAgIGlmIChteSAkZXJyID0gJEApIHsKLQljbGVhbnVwX2ZsZWVjaW5nX2ltYWdl cygkc2VsZiwgJGRpc2tzKTsKKwljbGVhbnVwX2ZsZWVjaW5nX2ltYWdlcygkc2VsZiwgJHZtaWQs ICRkaXNrcyk7CiAJZGllICRlcnI7CiAgICAgfQorCisgICAgUFZFOjpRZW11Q29uZmlnOjpyZWNv cmRfZmxlZWNpbmdfaW1hZ2VzKCR2bWlkLCAkZmxlZWNlX3ZvbGlkcyk7CiB9CiAKIG15IHN1YiBk ZXRhY2hfZmxlZWNpbmdfaW1hZ2VzIHsKQEAgLTYzMyw2ICs2NDYsMTMgQEAgbXkgc3ViIGNoZWNr X2FuZF9wcmVwYXJlX2ZsZWVjaW5nIHsKIAkkdXNlX2ZsZWVjaW5nID0gMDsKICAgICB9CiAKKyAg ICAjIGNsZWFuIHVwIHBvdGVudGlhbCBsZWZ0LW92ZXJzIGZyb20gYSBwcmV2aW91cyBhdHRlbXB0 CisgICAgZXZhbCB7CisJUFZFOjpRZW11Q29uZmlnOjpjbGVhbnVwX2ZsZWVjaW5nX2ltYWdlcygK KwkgICAgJHZtaWQsICRzZWxmLT57c3RvcmVjZmd9LCBzdWIgeyAkc2VsZi0+bG9nKCRfWzBdLCAk X1sxXSk7IH0pOworICAgIH07CisgICAgJHNlbGYtPmxvZygnd2FybicsICJhdHRlbXB0IHRvIGNs ZWFuIHVwIGxlZnQtb3ZlciBmbGVlY2luZyBpbWFnZXMgZmFpbGVkIC0gJEAiKSBpZiAkQDsKKwog ICAgIGlmICgkdXNlX2ZsZWVjaW5nKSB7CiAJbXkgKCRkZWZhdWx0X2Zvcm1hdCwgJHZhbGlkX2Zv cm1hdHMpID0gUFZFOjpTdG9yYWdlOjpzdG9yYWdlX2RlZmF1bHRfZm9ybWF0KAogCSAgICAkc2Vs Zi0+e3N0b3JlY2ZnfSwgJGZsZWVjaW5nX29wdHMtPntzdG9yYWdlfSk7CkBAIC03OTQsNyArODE0 LDggQEAgc3ViIGFyY2hpdmVfcGJzIHsKIAogICAgIGlmICgkdXNlX2ZsZWVjaW5nKSB7CiAJZGV0 YWNoX2ZsZWVjaW5nX2ltYWdlcygkdGFzay0+e2Rpc2tzfSwgJHZtaWQpOwotCWNsZWFudXBfZmxl ZWNpbmdfaW1hZ2VzKCRzZWxmLCAkdGFzay0+e2Rpc2tzfSk7CisJUFZFOjpRZW11Q29uZmlnOjpj bGVhbnVwX2ZsZWVjaW5nX2ltYWdlcygKKwkgICAgJHZtaWQsICRzZWxmLT57c3RvcmVjZmd9LCBz dWIgeyAkc2VsZi0+bG9nKCRfWzBdLCAkX1sxXSk7IH0pOwogICAgIH0KIAogICAgIGRpZSAkZXJy IGlmICRlcnI7CkBAIC05OTQsNyArMTAxNSw4IEBAIHN1YiBhcmNoaXZlX3ZtYSB7CiAKICAgICBp ZiAoJHVzZV9mbGVlY2luZykgewogCWRldGFjaF9mbGVlY2luZ19pbWFnZXMoJHRhc2stPntkaXNr c30sICR2bWlkKTsKLQljbGVhbnVwX2ZsZWVjaW5nX2ltYWdlcygkc2VsZiwgJHRhc2stPntkaXNr c30pOworCVBWRTo6UWVtdUNvbmZpZzo6Y2xlYW51cF9mbGVlY2luZ19pbWFnZXMoCisJICAgICR2 bWlkLCAkc2VsZi0+e3N0b3JlY2ZnfSwgc3ViIHsgJHNlbGYtPmxvZygkX1swXSwgJF9bMV0pOyB9 KTsKICAgICB9CiAKICAgICBpZiAoJGVycikgewotLSAKMi4zOS41CgoKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCnB2ZS1kZXZlbCBtYWlsaW5nIGxpc3QK cHZlLWRldmVsQGxpc3RzLnByb3htb3guY29tCmh0dHBzOi8vbGlzdHMucHJveG1veC5jb20vY2dp LWJpbi9tYWlsbWFuL2xpc3RpbmZvL3B2ZS1kZXZlbAo=