From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5B9931FF173 for ; Mon, 11 Nov 2024 14:55:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D37D8C35E; Mon, 11 Nov 2024 14:55:12 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Mon, 11 Nov 2024 14:54:31 +0100 Message-Id: <20241111135436.82773-5-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241111135436.82773-1-f.ebner@proxmox.com> References: <20241111135436.82773-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v4 qemu-server 4/9] backup: prepare: cancel previous job if still running X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This can happen after a hard failure, e.g. if the vzdump task was killed. The next backup (after unlocking the VM) would then fail with > ERROR: VM 125 qmp command 'backup' failed - previous backup not finished During the failure path of that attempt, 'backup-cancel' is executed and the subsequent attempt would then work again. Do it up-front with a warning instead of relying on this behavior. Signed-off-by: Fiona Ebner --- New in v4. PVE/VZDump/QemuServer.pm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm index bd4795ca..8ebe6772 100644 --- a/PVE/VZDump/QemuServer.pm +++ b/PVE/VZDump/QemuServer.pm @@ -59,6 +59,13 @@ sub prepare { my $running = PVE::QemuServer::Helpers::vm_running_locally($vmid); + if ($running && (my $status = mon_cmd($vmid, 'query-backup'))) { + if ($status->{status} && $status->{status} eq 'active') { + $self->log('warn', "left-over backup job still running inside QEMU - canceling now"); + mon_cmd($vmid, 'backup-cancel'); + } + } + $task->{disks} = []; my $conf = $self->{vmlist}->{$vmid} = PVE::QemuConfig->load_config($vmid); -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel