From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 09E1A1FF183 for ; Mon, 11 Nov 2024 12:05:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6E8B886F4; Mon, 11 Nov 2024 12:05:54 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 11 Nov 2024 12:05:18 +0100 Message-Id: <20241111110520.1803627-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241111110520.1803627-1-d.csapak@proxmox.com> References: <20241111110520.1803627-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH common v5 1/2] sysfstools: file_write: extend with logging X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" the actual error and path is useful to know when trying to debug or figure out what did not work, so warn here if there was an error. Signed-off-by: Dominik Csapak --- changes from v4: * extract $! before close src/PVE/SysFSTools.pm | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/PVE/SysFSTools.pm b/src/PVE/SysFSTools.pm index 0bde6d7..428e6ec 100644 --- a/src/PVE/SysFSTools.pm +++ b/src/PVE/SysFSTools.pm @@ -211,17 +211,24 @@ sub check_iommu_support{ return PVE::Tools::dir_glob_regex('/sys/class/iommu/', "[^\.].*"); } +# writes $buf into $filename, on success returns 1, on error returns 0 and warns sub file_write { my ($filename, $buf) = @_; my $fh = IO::File->new($filename, "w"); return undef if !$fh; - my $res = defined(syswrite($fh, $buf)) ? 1 : 0; - + my $res = syswrite($fh, $buf); + my $syserr = $!; # only relevant if $res is undefined $fh->close(); - return $res; + if (defined($res)) { + return 1; + } elsif ($syserr) { + warn "error writing '$buf' to '$filename': $syserr\n"; + } + + return 0; } sub pci_device_info { -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel