From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6E6A31FF168 for ; Mon, 11 Nov 2024 09:12:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1CE3F3CB5C; Mon, 11 Nov 2024 09:12:32 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 11 Nov 2024 09:12:26 +0100 Message-Id: <20241111081228.375675-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241111081228.375675-1-d.csapak@proxmox.com> References: <20241111081228.375675-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH common v3 1/2] sysfstools: file_write: extend with logging and ignore list X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" the actual error and path is useful to know when trying to debug or figure out what did not work, so warn here if there was an error. Now also takes an optional error list that can be ignored. If encountering such an error, returns success instead of failure. Signed-off-by: Dominik Csapak --- changes from v2: * enhance comment * improve commit message * shorten return statement * remove indentation by default initializing $ignore_list to [] src/PVE/SysFSTools.pm | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/PVE/SysFSTools.pm b/src/PVE/SysFSTools.pm index 0bde6d7..0aeff5f 100644 --- a/src/PVE/SysFSTools.pm +++ b/src/PVE/SysFSTools.pm @@ -211,17 +211,28 @@ sub check_iommu_support{ return PVE::Tools::dir_glob_regex('/sys/class/iommu/', "[^\.].*"); } +# writes $buf into $filename, returns false and warns on errors not listed in the optional $ignore_list +# error to ignore come from the POSIX module e.g. 'EEXIST' sub file_write { - my ($filename, $buf) = @_; + my ($filename, $buf, $ignore_list) = @_; + $ignore_list //= []; my $fh = IO::File->new($filename, "w"); return undef if !$fh; - my $res = defined(syswrite($fh, $buf)) ? 1 : 0; - + my $res = syswrite($fh, $buf); $fh->close(); - return $res; + if (defined($res)) { + return 1; + } elsif (my $err = $!) { + for my $to_ignore ($ignore_list->@*) { + return 1 if $err == $to_ignore; + } + warn "error writing '$buf' to '$filename': $err\n"; + } + + return 0; } sub pci_device_info { -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel