From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 25E041FF168 for ; Mon, 11 Nov 2024 09:13:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CBC783CC88; Mon, 11 Nov 2024 09:13:03 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 11 Nov 2024 09:12:25 +0100 Message-Id: <20241111081228.375675-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH common/qemu-server v3] improve sysfs write behaviour X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" and fix passthrough regressions As i feared previously in [0], making it a hard error when encountering errors during sysfs writes uncovered some situations where our code was too strict to keep some setups working. One such case is resetting devices, which is seemingly not necessary at all times, so this series * donwgrades that error to warning * adds some more logging to `file_write` to be able to better debug Another case that broke was passing through similar devices with the same vendor/modelid since the write to vfio-pci's 'new_id' works only once for the same vendor/modelid. To fix that make some errors ignorable for file_write changes from v2: * improve comment on file_write * shorten code with suggestions from stoiko * fix commit message changes from v1: * also include error ignore list * ignore EEXIST for writing to new_id 0: https://lore.proxmox.com/pve-devel/20240723082925.934603-1-d.csapak@proxmox.com/ pve-common: Dominik Csapak (2): sysfstools: file_write: extend with logging and ignore list sysfstools: fix regression on binding to vfio-pci src/PVE/SysFSTools.pm | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) qemu-server: Dominik Csapak (1): pci: don't hard require resetting devices for passthrough PVE/QemuServer/PCI.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel