From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 2FA311FF164 for ; Fri, 8 Nov 2024 14:06:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DC079DF3F; Fri, 8 Nov 2024 14:06:19 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Fri, 8 Nov 2024 14:05:32 +0100 Message-ID: <20241108130537.1266472-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.47.0 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH installer v2 0/4] auto-install-assistant: allow specifying 'fetch-from' partition label X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This series allow specifying the partition label the `proxmox-fetch-answer` tool will search when trying to retrieve an answer file in the 'partition' fetch mode. This has been requested by at least one user one user [0] and definitely makes sense, esp. for BMCs/IPMIs where one might not be able to control the partition label. Patch #1 implements the new CLI parameter in the `proxmox-auto-install-assistant` tool, patch #4 then integrates it into the `proxmox-fetch-answer` itself. Patch #2 is just a small (but needed) refactor of the CLI parsing code. Patch #3 implements also searching for the partition label in the exact case it was specified by the user. This is something I stumbled over while testing it - see the patch itself for some more information. [0] https://forum.proxmox.com/threads/proxmox-ais-question-request.153043/post-695689 History ======= v1: https://lore.proxmox.com/pve-devel/20241018115943.813243-1-c.heiss@proxmox.com/ Notable Changes v1 -> v2: * addressed suggestions by Aaron * added Aaron's T-b & R-b tags, thanks! * dropped useless "proxmox-ais" explanation from --prepare-iso description Diffstat ======== Christoph Heiss (4): auto-install-assistant: add new parameter to specify partition label fetch-answer: refactor cli argument parsing fetch-answer: partition: also search for exact-matching partition label fetch-answer: use partition label from fetch config instead of hardcoded proxmox-auto-install-assistant/src/main.rs | 15 ++++- proxmox-auto-installer/src/utils.rs | 1 + .../src/fetch_plugins/partition.rs | 32 ++++++---- proxmox-fetch-answer/src/main.rs | 58 ++++++++++++++----- 4 files changed, 80 insertions(+), 26 deletions(-) -- 2.46.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel