From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id CC55E1FF164 for ; Fri, 8 Nov 2024 11:28:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 53B2CB47E; Fri, 8 Nov 2024 11:28:24 +0100 (CET) Date: Fri, 8 Nov 2024 11:28:20 +0100 From: Stoiko Ivanov To: Dominik Csapak Message-ID: <20241108112820.77697a48@rosa.proxmox.com> In-Reply-To: <20241108093300.1023657-1-d.csapak@proxmox.com> References: <20241108093300.1023657-1-d.csapak@proxmox.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH common/qemu-server v2] improve sysfs write behaviour X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" gave this another spin on my reproducer for the failing device-reset - still works fine! 2 cosmetic nits for the patches aside - which from my pov can also be left as is (or maybe fixed up when applying): Tested-by: Stoiko Ivanov Reviewed-by: Stoiko Ivanov On Fri, 8 Nov 2024 10:32:57 +0100 Dominik Csapak wrote: > and fix passthrough regressions > > As i feared previously in [0], making it a hard error when encountering > errors during sysfs writes uncovered some situations where our code was > too strict to keep some setups working. > > One such case is resetting devices, which is seemingly not necessary > at all times, so this series > > * donwgrades that error to warning > * adds some more logging to `file_write` to be able to better debug > > Another case that broke was passing through similar devices with the > same vendor/modelid since the write to vfio-pci's 'new_id' works only > once for the same vendor/modelid. > > To fix that make some errors ignorable for file_write > > changes from v1: > * also include error ignore list > * ignore EEXIST for writing to new_id > > 0: https://lore.proxmox.com/pve-devel/20240723082925.934603-1-d.csapak@proxmox.com/ > > pve-common: > > Dominik Csapak (2): > sysfstools: file_write: extend with logging and ignore list > sysfstools: fix regression on binding to vfio-pci > > src/PVE/SysFSTools.pm | 25 ++++++++++++++++++++----- > 1 file changed, 20 insertions(+), 5 deletions(-) > > qemu-server: > > Dominik Csapak (1): > pci: don't hard require resetting devices for passthrough > > PVE/QemuServer/PCI.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel