From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 1BFA61FF164
for <inbox@lore.proxmox.com>; Fri, 8 Nov 2024 11:26:08 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id D4F0DB376;
Fri, 8 Nov 2024 11:26:08 +0100 (CET)
Date: Fri, 8 Nov 2024 11:26:06 +0100
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Message-ID: <20241108112606.0d47d65d@rosa.proxmox.com>
In-Reply-To: <20241108093300.1023657-3-d.csapak@proxmox.com>
References: <20241108093300.1023657-1-d.csapak@proxmox.com>
<20241108093300.1023657-3-d.csapak@proxmox.com>
X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu)
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.071 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH common v2 2/2] sysfstools: fix regression on
binding to vfio-pci
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On Fri, 8 Nov 2024 10:32:59 +0100
Dominik Csapak <d.csapak@proxmox.com> wrote:
> when starting a vm with passthrough, we have to bind all normal pci
> devices to vfio-pci. This happens by
>
> * unbinding from current driver
> * telling vfio-pci the 'vendorid modelid' combo to it know this device
s/to it know/so it knows/ ?
> class can use the driver (by writing to 'new_id')
> * actually binding the device to vfio-pci
>
> if there are multiple devices of the same 'vendorid modelid' class on
> the host (and passed through), only the first write to 'new_id' is
> successful, all subsequent ones return EEXIST.
>
> This could happen e.g. for setups with multiple GPUs that have the same
> audio chip.
>
> To fix this, ignore the EEXIST error for this write to new_id
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/PVE/SysFSTools.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/SysFSTools.pm b/src/PVE/SysFSTools.pm
> index 156fee6..569693e 100644
> --- a/src/PVE/SysFSTools.pm
> +++ b/src/PVE/SysFSTools.pm
> @@ -4,6 +4,7 @@ use strict;
> use warnings;
>
> use IO::File;
> +use POSIX qw(EEXIST);
>
> use PVE::Tools qw(file_read_firstline dir_glob_foreach);
>
> @@ -317,7 +318,7 @@ sub pci_dev_bind_to_vfio {
> return 1 if -d $testdir;
>
> my $data = "$dev->{vendor} $dev->{device}";
> - return undef if !file_write("$vfio_basedir/new_id", $data);
> + return undef if !file_write("$vfio_basedir/new_id", $data, [EEXIST]);
>
> my $fn = "$pcisysfs/devices/$name/driver/unbind";
> if (!file_write($fn, $name)) {
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel