From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2F9FF1FF166 for ; Fri, 8 Nov 2024 10:33:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 85C9FA3E2; Fri, 8 Nov 2024 10:33:33 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Fri, 8 Nov 2024 10:32:59 +0100 Message-Id: <20241108093300.1023657-3-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241108093300.1023657-1-d.csapak@proxmox.com> References: <20241108093300.1023657-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH common v2 2/2] sysfstools: fix regression on binding to vfio-pci X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" when starting a vm with passthrough, we have to bind all normal pci devices to vfio-pci. This happens by * unbinding from current driver * telling vfio-pci the 'vendorid modelid' combo to it know this device class can use the driver (by writing to 'new_id') * actually binding the device to vfio-pci if there are multiple devices of the same 'vendorid modelid' class on the host (and passed through), only the first write to 'new_id' is successful, all subsequent ones return EEXIST. This could happen e.g. for setups with multiple GPUs that have the same audio chip. To fix this, ignore the EEXIST error for this write to new_id Signed-off-by: Dominik Csapak --- src/PVE/SysFSTools.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/SysFSTools.pm b/src/PVE/SysFSTools.pm index 156fee6..569693e 100644 --- a/src/PVE/SysFSTools.pm +++ b/src/PVE/SysFSTools.pm @@ -4,6 +4,7 @@ use strict; use warnings; use IO::File; +use POSIX qw(EEXIST); use PVE::Tools qw(file_read_firstline dir_glob_foreach); @@ -317,7 +318,7 @@ sub pci_dev_bind_to_vfio { return 1 if -d $testdir; my $data = "$dev->{vendor} $dev->{device}"; - return undef if !file_write("$vfio_basedir/new_id", $data); + return undef if !file_write("$vfio_basedir/new_id", $data, [EEXIST]); my $fn = "$pcisysfs/devices/$name/driver/unbind"; if (!file_write($fn, $name)) { -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel