From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 755BD1FF164 for ; Wed, 6 Nov 2024 12:38:01 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 48C21D51A; Wed, 6 Nov 2024 12:38:10 +0100 (CET) From: Daniel Herzig To: pve-devel@lists.proxmox.com Date: Wed, 6 Nov 2024 12:37:25 +0100 Message-Id: <20241106113725.48415-1-d.herzig@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.010 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit] node/ServiceView: fix #5611: hiding the non-installed services X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This patch adds a filter to identify services, which are reported as 'not-found' by the api. By default they will not be shown in the UI anymore, but visibility can still be toggled using a new checkbox. Signed-off-by: Daniel Herzig --- src/node/ServiceView.js | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/src/node/ServiceView.js b/src/node/ServiceView.js index 19cfc18..f1c2e5f 100644 --- a/src/node/ServiceView.js +++ b/src/node/ServiceView.js @@ -29,6 +29,10 @@ Ext.define('Proxmox.node.ServiceView', { }, }); + let hide_not_installed = function(record) { + return record.get('unit-state') !== 'not-found'; + }; + let store = Ext.create('Proxmox.data.DiffStore', { rstore: rstore, sortAfterUpdate: true, @@ -38,6 +42,24 @@ Ext.define('Proxmox.node.ServiceView', { direction: 'ASC', }, ], + filters: [ + hide_not_installed, + ], + }); + + let unHideCB = Ext.create('Ext.form.field.Checkbox', { + boxLabel: gettext('Show non-installed services'), + value: false, + boxLabelAlign: 'before', + listeners: { + change: function(_cb, value) { + if (value) { + store.clearFilter(); + } else { + store.addFilter([hide_not_installed]); + } + }, + }, }); let view_service_log = function() { @@ -166,6 +188,8 @@ Ext.define('Proxmox.node.ServiceView', { restart_btn, '-', syslog_btn, + '->', + unHideCB, ], columns: [ { -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel