From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 218471FF161 for ; Tue, 5 Nov 2024 11:17:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E65B51D727; Tue, 5 Nov 2024 11:17:30 +0100 (CET) Date: Tue, 5 Nov 2024 11:16:57 +0100 From: Stoiko Ivanov To: Dominik Csapak Message-ID: <20241105111657.18f7053b@rosa.proxmox.com> In-Reply-To: <20241105092421.774448-3-d.csapak@proxmox.com> References: <20241105092421.774448-1-d.csapak@proxmox.com> <20241105092421.774448-3-d.csapak@proxmox.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.072 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server 1/1] pci: don't hard require resetting devices for passthrough X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Tue, 5 Nov 2024 10:24:21 +0100 Dominik Csapak wrote: > Since pve-common commit: > > eff5957 (sysfstools: file_write: properly catch errors) > > this check here fails now when the reset does not work. It turns out > that resetting the device is not always necessary, and we previously > ignored most errors when trying to do so. > > To restore that functionality, downgrade this `die` to a warning. > > If the device really needs a reset to work, it will either fail later > during startup, or not work correctly in the guest, but that behavior > existed before and is AFAIK not really detectable from our side. > > Signed-off-by: Dominik Csapak > --- > PVE/QemuServer/PCI.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/QemuServer/PCI.pm b/PVE/QemuServer/PCI.pm > index 75eac134..dceb8938 100644 > --- a/PVE/QemuServer/PCI.pm > +++ b/PVE/QemuServer/PCI.pm > @@ -728,7 +728,7 @@ sub prepare_pci_device { > } else { > die "can't unbind/bind PCI group to VFIO '$pciid'\n" > if !PVE::SysFSTools::pci_dev_group_bind_to_vfio($pciid); > - die "can't reset PCI device '$pciid'\n" > + warn "can't reset PCI device '$pciid'\n" maybe the issue would get more visiblity if we used PVE::RESTEnvironment::log_warn here? not really sure if it makes sense to mark the start tasks specifically for something that worked before without any logline indicating that something was off - but as I somehow expected to see the task with a warning - I thought I'd drop this here > if $info->{has_fl_reset} && !PVE::SysFSTools::pci_dev_reset($info); > } > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel