From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 30FE61FF161 for <inbox@lore.proxmox.com>; Tue, 5 Nov 2024 11:12:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 764F11D68B; Tue, 5 Nov 2024 11:13:00 +0100 (CET) Date: Tue, 5 Nov 2024 11:12:56 +0100 From: Stoiko Ivanov <s.ivanov@proxmox.com> To: Dominik Csapak <d.csapak@proxmox.com> Message-ID: <20241105111256.2a2c83e1@rosa.proxmox.com> In-Reply-To: <20241105092421.774448-1-d.csapak@proxmox.com> References: <20241105092421.774448-1-d.csapak@proxmox.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.072 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [sysfstools.pm, proxmox.com, pci.pm] Subject: Re: [pve-devel] [PATCH common/qemu-server] improve sysfs write behaviour X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Thanks big-time for the quick fix! I encountered this at a machine at home with an older GPU (NVIDIA GT1030) passed through to a VM, which seemingly does not handle resets too well. with both patches applied the guest starts again w/o error - the tasklog contains: ``` error writing '1' to '/sys/bus/pci/devices/0000:01:00.0/reset': Inappropriate ioctl for device can't reset PCI device '0000:01:00.0' ``` (similarly this is the output when starting on the commandline with `qm start <vmid>`) with or without the nit/idea for the qemu-server 1/1 patch consider this: Reviewed-by: Stoiko Ivanov <s.ivanov@proxmox.com> Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com> On Tue, 5 Nov 2024 10:24:19 +0100 Dominik Csapak <d.csapak@proxmox.com> wrote: > As i feared previously in [0], making it a hard error when encountering > errors during sysfs writes uncovered some situations where our code was > too strict to keep some setups working. > > One such case is resetting devices, which is seemingly not necessary > at all times, so this series > > * donwgrades that error to warning > * adds some more logging to `file_write` to be able to better debug > > Alternatively, we could rewrite file_write such that we can control the > error behaviour with a parameter and replace all "old" call sites so > that we ignore errors. But since the only other call sites currently are > for binding vfio-pci to the device. (which AFAIK is necessary and not > optional) and setting mdev models (which is also not optional), we should > mostly be fine with this approach here. > > In [1], some users reported it's breaking, at least one with binding of > vfio-pci, which I'm currently investigating there to see if it's really > necessary. > > 0: https://lore.proxmox.com/pve-devel/20240723082925.934603-1-d.csapak@proxmox.com/ > 1: https://forum.proxmox.com/threads/156848/ > > pve-common: > > Dominik Csapak (1): > sysfstools: file_write: log the actual error if there was one > > src/PVE/SysFSTools.pm | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > qemu-server: > > Dominik Csapak (1): > pci: don't hard require resetting devices for passthrough > > PVE/QemuServer/PCI.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel